Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add N&N entry for the Edge Browser. #250

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

fedejeanne
Copy link
Contributor

@fedejeanne fedejeanne commented Nov 13, 2024

Encourage the community to use Edge in Windows instead of IE and to report back any findings.

Contributes to eclipse-platform/eclipse.platform.swt#1466

Requires

@fedejeanne
Copy link
Contributor Author

@HeikoKlare , @sratz WDYT?
I'd say we wait until the flickering effect has been addressed before we push for Edge. The good news is that there is already a PR that proposes a fix: eclipse-platform/eclipse.platform.swt#1588 .

news/4.34/platform.html Outdated Show resolved Hide resolved
news/4.34/platform.html Outdated Show resolved Hide resolved
news/4.34/platform.html Outdated Show resolved Hide resolved
news/4.34/platform.html Outdated Show resolved Hide resolved
@fedejeanne fedejeanne force-pushed the nandn_edge branch 2 times, most recently from 889f507 to 0f77d29 Compare November 13, 2024 12:27
@fedejeanne fedejeanne marked this pull request as draft November 13, 2024 12:52
@fedejeanne
Copy link
Contributor Author

I switched to Draft until we decide if this N&N is for RC1 or for the next M1.

Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should we defer this to M1 (i.e., to the news for the next release)? With the next release, we hopefully have Edge as default, so the news information will be accordingly different.

news/4.34/platform.html Outdated Show resolved Hide resolved
news/4.34/platform.html Outdated Show resolved Hide resolved
news/4.34/platform.html Outdated Show resolved Hide resolved
news/4.34/platform.html Outdated Show resolved Hide resolved
news/4.34/platform.html Outdated Show resolved Hide resolved
@fedejeanne
Copy link
Contributor Author

Why should we defer this to M1 (i.e., to the news for the next release)? With the next release, we hopefully have Edge as default, so the news information will be accordingly different.

See #250 (comment)

@HeikoKlare
Copy link
Contributor

Why should we defer this to M1 (i.e., to the news for the next release)? With the next release, we hopefully have Edge as default, so the news information will be accordingly different.

See #250 (comment)

I still do not understand. We will not have that PR for the flickering be merged for the upcoming release. So if we wait for that to be merged to publish a news, we will not have any news for the upcoming release on this topic at all. That renders the work we are doing here on formulating the news useless. And I thought we had agreed on having a news on the topic for this release.

@fedejeanne
Copy link
Contributor Author

I still do not understand. We will not have that PR for the flickering be merged for the upcoming release. So if we wait for that to be merged to publish a news, we will not have any news for the upcoming release on this topic at all.

How would you inform the community about the open issue and the fact that it may cause seizures?

@HeikoKlare
Copy link
Contributor

I still do not understand. We will not have that PR for the flickering be merged for the upcoming release. So if we wait for that to be merged to publish a news, we will not have any news for the upcoming release on this topic at all.

How would you inform the community about the open issue and the fact that it may cause seizures?

We could write that into the news.

@fedejeanne
Copy link
Contributor Author

We could write that into the news.

Would you be open to crafting a notice so I can include it in this N&N?

@HeikoKlare
Copy link
Contributor

Maybe something like this?

<p>
<b>Note:</b> Changing the size of the browser window can currently cause flickering effects, which are currently being resolved. People who are sensitive to this should therefore either not use Edge at the moment or possibly avoid resizing browser windows.
</p>

@fedejeanne
Copy link
Contributor Author

Thank you, I added your text. I put it in a box (<fieldset>) with a legend of Warning (instead of Note) and I added a subtitle too.

@HeikoKlare
Copy link
Contributor

Looks good. I would prefer to have the warning box at the bottom instead of starting the section with a warning, but that may rather be personal preference.
Beyond that, only the entry in the list of improvements needs to be fixed.

Several issues have been addressed. The N&N mentions this and encourages
the community to activate Edge as the browser of choice and report back
any findings.

Co-authored-by: Heiko Klare <[email protected]>
@fedejeanne fedejeanne merged commit 7be6486 into eclipse-platform:master Nov 15, 2024
1 check passed
@fedejeanne
Copy link
Contributor Author

I put the warning on top on purpose so it draws more attention.
I changed the formulation so it doesn't read as "we inherited"

@fedejeanne fedejeanne deleted the nandn_edge branch November 15, 2024 06:58
@HeikoKlare
Copy link
Contributor

I put the warning on top on purpose so it draws more attention.

It is in an unmissable "warning" box already and now blocks from reading the actual, essential information (just my two cents).

I changed the formulation so it doesn't read as "we inherited"

Sounds good 👍

@vogella
Copy link
Contributor

vogella commented Nov 15, 2024

I suggest that we are not very strict in general with N&N. A entry for new stuff I good but 25 comments for an entry feels like a lot of work for only a small benefit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants