-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add N&N entry for the Edge Browser. #250
Conversation
@HeikoKlare , @sratz WDYT? |
889f507
to
0f77d29
Compare
I switched to Draft until we decide if this N&N is for RC1 or for the next M1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why should we defer this to M1 (i.e., to the news for the next release)? With the next release, we hopefully have Edge as default, so the news information will be accordingly different.
See #250 (comment) |
0f77d29
to
aadd1a4
Compare
I still do not understand. We will not have that PR for the flickering be merged for the upcoming release. So if we wait for that to be merged to publish a news, we will not have any news for the upcoming release on this topic at all. That renders the work we are doing here on formulating the news useless. And I thought we had agreed on having a news on the topic for this release. |
How would you inform the community about the open issue and the fact that it may cause seizures? |
We could write that into the news. |
Would you be open to crafting a notice so I can include it in this N&N? |
Maybe something like this?
|
aadd1a4
to
af5a700
Compare
Thank you, I added your text. I put it in a box ( |
Looks good. I would prefer to have the warning box at the bottom instead of starting the section with a warning, but that may rather be personal preference. |
Several issues have been addressed. The N&N mentions this and encourages the community to activate Edge as the browser of choice and report back any findings. Co-authored-by: Heiko Klare <[email protected]>
af5a700
to
bd9daa9
Compare
I put the warning on top on purpose so it draws more attention. |
It is in an unmissable "warning" box already and now blocks from reading the actual, essential information (just my two cents).
Sounds good 👍 |
I suggest that we are not very strict in general with N&N. A entry for new stuff I good but 25 comments for an entry feels like a lot of work for only a small benefit. |
Encourage the community to use Edge in Windows instead of IE and to report back any findings.
Contributes to eclipse-platform/eclipse.platform.swt#1466
Requires