Fix tests in org.eclipse.core.expressions.tests #525 #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael5601
changed the title
Test Results 42 files ±0 42 suites ±0 53m 35s ⏱️ - 1m 13s For more details on these failures, see this check. Results for commit d1e8c73. ± Comparison against base commit d3a1f1d. ♻️ This comment has been updated with latest results. |
|
Failing test documented in #628. |
HeikoKlare
reviewed
Sep 1, 2023
There was a problem hiding this comment.
Thanks for adding the missing functionality and enabling the according tests!
The changes look sound to me. Tests work as expected. I would only suggest to apply a minor refactoring moving to recent Java features, since the code is touched anyway (see code comment).
...e/bundles/org.eclipse.core.expressions/src/org/eclipse/core/expressions/CountExpression.java
Outdated
Show resolved
Hide resolved
Michael5601
force-pushed
the
CountExpressionTests
branch
from
1dc34ed
to
006404b
Compare
HeikoKlare
force-pushed
the
CountExpressionTests
branch
from
006404b
to
aa03cff
Compare
HeikoKlare
approved these changes
Sep 8, 2023
HeikoKlare
force-pushed
the
CountExpressionTests
branch
from
50c656d
to
228a679
Compare
…rm#525 This commit fixes the tests testLessThanOrEqualToExpression and testGreaterThanOrEqualToExpression of class CountExpression.java by adding additional functionality similar to the already existing. Contributes to eclipse-platform#525.
HeikoKlare
force-pushed
the
CountExpressionTests
branch
from
228a679
to
d1e8c73
Compare
|
Failing test documented in #668 |
This was referenced Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the tests testLessThanOrEqualToExpression and testGreaterThanOrEqualToExpression of class CountExpression.java in org.eclipse.core.expressions.tests by adding additional functionality similar to the already existing. Contributes to #525.