Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactivate tests in org.eclipse.debug.tests #525 #617

Merged

Conversation

Michael5601
Copy link
Contributor

This change reactivates all working disabled tests from project org.eclipse.debug.tests. The tests were forgotten after the corresponding bug was fixed. Contributes to #525

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Test Results

       42 files  ±0         42 suites  ±0   58m 57s ⏱️ + 8m 50s
  3 763 tests +1    3 760 ✔️ +2    3 💤  - 1  0 ±0 
11 292 runs  +3  11 265 ✔️ +6  27 💤  - 3  0 ±0 

Results for commit a48ad04. ± Comparison against base commit cebe637.

♻️ This comment has been updated with latest results.

@Michael5601 Michael5601 changed the title Reactivate tests #525 Reactivate tests in org.eclipse.debug.tests #525 Aug 7, 2023
Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reactivated ContentTests.testChildrenUpdatesCompletedOutOfSequence fails in CI builds.

The reactivated JFaceViewerDeltaTests.testBug292322 does not terminate. It is not executed during CI builds (they run the VirtualViewerContentTests rather than the JFaceViewerDeltaTests), so that CI builds do not reveal that failure.

Please remove those two test reactivations from this PR and document them. I propose to do that at the disabled test documentation in the umbrella issue #525.

The other two tests work fine, both locally from within Eclipse and in Maven builds. They succeed on all platforms in CI builds.

@Michael5601 Michael5601 force-pushed the org.eclipse.debug.tests branch 4 times, most recently from a1da4ac to 4161746 Compare August 9, 2023 12:11
This change reactivates all working disabled tests from project org.eclipse.debug.tests. The tests were forgotten after the corresponding bug was fixed.
Contributes to eclipse-platform#525
@Michael5601
Copy link
Contributor Author

The reactivated ContentTests.testChildrenUpdatesCompletedOutOfSequence fails in CI builds.

The reactivated JFaceViewerDeltaTests.testBug292322 does not terminate. It is not executed during CI builds (they run the VirtualViewerContentTests rather than the JFaceViewerDeltaTests), so that CI builds do not reveal that failure.

Please remove those two test reactivations from this PR and document them. I propose to do that at the disabled test documentation in the umbrella issue #525.

The other two tests work fine, both locally from within Eclipse and in Maven builds. They succeed on all platforms in CI builds.

I removed the two failing tests from the commit and documented them in #525.

@HeikoKlare HeikoKlare merged commit 87c99cb into eclipse-platform:master Aug 9, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants