-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reactivate tests in org.eclipse.debug.tests #525 #617
Reactivate tests in org.eclipse.debug.tests #525 #617
Conversation
49fd34a
to
e683ca8
Compare
e683ca8
to
c9a76e8
Compare
7f37aec
to
e683ca8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reactivated ContentTests.testChildrenUpdatesCompletedOutOfSequence
fails in CI builds.
The reactivated JFaceViewerDeltaTests.testBug292322
does not terminate. It is not executed during CI builds (they run the VirtualViewerContentTests
rather than the JFaceViewerDeltaTests
), so that CI builds do not reveal that failure.
Please remove those two test reactivations from this PR and document them. I propose to do that at the disabled test documentation in the umbrella issue #525.
The other two tests work fine, both locally from within Eclipse and in Maven builds. They succeed on all platforms in CI builds.
a1da4ac
to
4161746
Compare
This change reactivates all working disabled tests from project org.eclipse.debug.tests. The tests were forgotten after the corresponding bug was fixed. Contributes to eclipse-platform#525
4161746
to
a48ad04
Compare
I removed the two failing tests from the commit and documented them in #525. |
This change reactivates all working disabled tests from project org.eclipse.debug.tests. The tests were forgotten after the corresponding bug was fixed. Contributes to #525