Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing Test: SaveParticipantTest.test3 #651

Closed
jukzi opened this issue Aug 30, 2023 · 3 comments
Closed

Failing Test: SaveParticipantTest.test3 #651

jukzi opened this issue Aug 30, 2023 · 3 comments

Comments

@jukzi
Copy link
Contributor

jukzi commented Aug 30, 2023

org.eclipse.core.tests.resources.session.SaveParticipantTest

the test is not used for almost 20 years. It was once listed as comment in org.eclipse.core.tests.resources.session.AllSessionTests
from 2d6f69d722d1fb50ad084fc05d3d08c0e3ceac7c

until 31a4b42f024e545077240af22e1349e34425ed07
@jukzi
Copy link
Contributor Author

jukzi commented Aug 30, 2023 

junit.framework.AssertionFailedError: 6.0
	at junit.framework.Assert.fail(Assert.java:57)
	at junit.framework.TestCase.fail(TestCase.java:223)
	at org.eclipse.core.tests.resources.saveparticipant.SaveManager3Test.testSaveParticipant(SaveManager3Test.java:143)
	at org.eclipse.core.tests.resources.saveparticipant.SaveManagerTest.test3(SaveManagerTest.java:104)

logging

delta is different than expected
Verifying delta for /
Verifying delta for /MyProject
Verifying delta for /MyProject/addedFile
Verifying delta for /Project2
Verifying delta for /Project2/.project
Verifying delta for /Project2/.settings
	Missing expected change
		Actual kind: <ADDED>
		Actual change flags: <0>
Verifying delta for /Project2/.settings/org.eclipse.core.resources.prefs
	Missing expected change
		Actual kind: <ADDED>
		Actual change flags: <0>
Verifying delta for /Project2/addedFile
Verifying delta for /Project2/file110
Verifying delta for /Project2/folder110
Verifying delta for /Project2/folder110/file120
Verifying delta for /Project2/folder111
Verifying delta for /Project2/folder111/file121

@jukzi
Copy link
Contributor Author

jukzi commented Aug 30, 2023 •
edited
Loading

regression from https://bugs.eclipse.org/bugs/show_bug.cgi?id=479450
"a new project will always have .settings/org.eclipse.core.resources.prefs file generated, containing information about project default encoding."

jukzi pushed a commit to jukzi/eclipse.platform that referenced this issue Aug 30, 2023
@EcljpseB0T
fix SaveParticipantTest.test3 eclipse-platform#651
7796236 
eclipse-platform#651

"a new project will always have
.settings/org.eclipse.core.resources.prefs file generated, containing
information about project default encoding."

https://bugs.eclipse.org/bugs/show_bug.cgi?id=479450
@jukzi jukzi mentioned this issue Aug 30, 2023
Merged
jukzi pushed a commit to jukzi/eclipse.platform that referenced this issue Sep 11, 2023
@EcljpseB0T @jukzi
fix SaveParticipantTest.test3 eclipse-platform#651
d78c6ba 
eclipse-platform#651

"a new project will always have
.settings/org.eclipse.core.resources.prefs file generated, containing
information about project default encoding."

https://bugs.eclipse.org/bugs/show_bug.cgi?id=479450
jukzi pushed a commit that referenced this issue Sep 11, 2023
@EcljpseB0T @jukzi
fix SaveParticipantTest.test3 #651
d3a1f1d 
#651

"a new project will always have
.settings/org.eclipse.core.resources.prefs file generated, containing
information about project default encoding."

https://bugs.eclipse.org/bugs/show_bug.cgi?id=479450
@HeikoKlare
Copy link
Contributor

fixed via #652

fedejeanne pushed a commit to fedejeanne/eclipse.platform that referenced this issue Sep 13, 2023
@EcljpseB0T @fedejeanne
fix SaveParticipantTest.test3 eclipse-platform#651
ffb3fa7 
eclipse-platform#651

"a new project will always have
.settings/org.eclipse.core.resources.prefs file generated, containing
information about project default encoding."

https://bugs.eclipse.org/bugs/show_bug.cgi?id=479450
fedejeanne pushed a commit to fedejeanne/eclipse.platform that referenced this issue Sep 13, 2023
@EcljpseB0T @fedejeanne
fix SaveParticipantTest.test3 eclipse-platform#651
c52c95a 
eclipse-platform#651

"a new project will always have
.settings/org.eclipse.core.resources.prefs file generated, containing
information about project default encoding."

https://bugs.eclipse.org/bugs/show_bug.cgi?id=479450
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HeikoKlare @jukzi