Migrate to Java 17 switch #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Please squash the commits into one and avoid merge commits in future contriburtions. |
preveen-stack
force-pushed
the
java_17_switch
branch
from
985aa1c
to
8464f5e
Compare
|
@vogella Commits squashed |
|
ECA completed |
HannesWell
reviewed
Apr 20, 2023
...s/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/search/UseScanParser.java
Outdated
Show resolved
Hide resolved
|
LGTM Any more suggestions @HannesWell ? |
I'll review it tomorrow. |
HannesWell
force-pushed
the
java_17_switch
branch
from
e5791f1
to
716d206
Compare
HannesWell
approved these changes
May 1, 2023
There was a problem hiding this comment.
The change looks good.
But at some places I think the use of switches is not so well suited and if/else/else-if statements are a better fit. But that was already the case before.
Nevertheless I changed those places to use if-statements instead.
In general I think many of the switch-expressions should be pattern-matches, but that will require Java-21 or even later (see #592).
Besides that I added missing default cases that caused warnings.
- changed to Java 17 Switch Expression - replace switch-statements by if/else-statements where suitable Co-authored-by: Hannes Wellmann <[email protected]>
|
Thank you @preveen-stack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace legacy switch block with java 17 semantics
ref: https://openjdk.org/jeps/361
PS: This is my first PR in eclipse-pde.