Check getBundle returns non-null after PDE Manifest-editor opened. #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HannesWell , @laeubi , @alshamams , i can`t add reviewers for this PR. can you guys review it. |
|
Will will need to get an ECA in place: |
|
I`m closing this PR and create new PR with primary email id. |
peddaiahjuturu
deleted the
bugs/1374_after_opening_MANIFEST_file_geting_NPE_on_project_delete
branch
You can always force-push amended commits to the branch of a Pull-Request. And while amending a commit you can also change the author/commiter mail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug description
(Regression introduced by #949 and reported in #864)
After opening MANIFEST.MF file in PDE Manifest-editor and delete the project, ll get NPE.