Remove fragment attribute from the feature.xml file.

eclipse-pde · Sep 30, 2023 · 9eb4d51 · 9eb4d51
1 parent 653f498
commit 9eb4d51
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/builders/FeatureErrorReporter.java b/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/builders/FeatureErrorReporter.java
@@ -109,12 +109,21 @@ private void validatePlugins(Element parent) {
 			assertAttributeDefined(plugin, "id", CompilerFlags.ERROR); //$NON-NLS-1$
 			assertAttributeDefined(plugin, "version", CompilerFlags.ERROR); //$NON-NLS-1$
 			NamedNodeMap attributes = plugin.getAttributes();
-			boolean isFragment = plugin.getAttribute("fragment").equals("true"); //$NON-NLS-1$ //$NON-NLS-2$
 			for (int j = 0; j < attributes.getLength(); j++) {
 				Attr attr = (Attr) attributes.item(j);
 				String name = attr.getName();
 				if (name.equals("id")) { //$NON-NLS-1$
-					validatePluginExists(plugin, attr, isFragment);
+					String id = attr.getValue();
+					int severity = CompilerFlags.getFlag(fProject, CompilerFlags.F_UNRESOLVED_PLUGINS);
+					if (severity != CompilerFlags.IGNORE) {
+						IPluginModelBase model = PluginRegistry.findModel(id);
+						if (model == null || !model.isEnabled()) {
+							VirtualMarker marker = report(NLS.bind(PDECoreMessages.Builders_Feature_reference, id),
+									getLine(plugin, attr.getName()), severity, PDEMarkerFactory.CAT_OTHER);
+							addMarkerAttribute(marker, PDEMarkerFactory.compilerKey,
+									CompilerFlags.F_UNRESOLVED_PLUGINS);
+						}
+					}
 				} else if (name.equals("version")) { //$NON-NLS-1$
 					validateVersionAttribute(plugin, attr);
 					validateVersion(plugin, attr);