-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only add Authorization header if token exists #6
only add Authorization header if token exists #6
Conversation
This patch makes the database config "token" optional. Users can either set it to an empty string or omit the token completely. This is useful for DB-APIs that do not require authentication, and therefore no token.
build output and caches can be ignored by git
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still no update available to fix the bug with werkzeug, therefore LGTM.
@dabm-git The changes from this PR seem to be included in #9 too? Can this PR still be merged or has it been superseeded by #9? Do we require additional approval from @zaalizadeh / @Zakieh2020 ? |
Regarding the second question, |
Ok. Since we already have @dabm-git 's approval I suggest to merge this so that we get a working version of service-discovery - and update / handle #9 subsequently. |
This patch makes the database config "token" optional. Users can either set it to an empty string or omit the token completely. This is useful for DB-APIs that do not require authentication, and therefore no token.
Also closes #7
It is necessary to pin the werkzeug dependency to version
2.0.*
. Otherwise, service-discovery will fail to start with:See python-restx/flask-restx#460
service-discovery probably should update its dependencies as soon as there is an updated version of flask-restx available.