Sonar Scanner folder removed and added in dockerfile #4

[nikosnikolaidis]

In order to start a SonarQube analysis the Sonar Scanner folder was added in this repo in the begging.
But as this is not optimal and is also related to issue #4, I removed this folder and added it only in the build of the docker image.

[nikosnikolaidis]

@deanone this pull request is also stuck in some checks like this. Do you know why?

[deanone]

@nikosnikolaidis most probably someone with write access should make a review for this PR in order for the checks to proceed. I just accepted the changes.

[nikosnikolaidis]

@deanone the checks continue to appear to be pending. Any thoughts?

[nikosnikolaidis]

Dear @philipreimer,

Do you maybe know why the pull requests of this repo and the followings are stuck in the dependabot check?

• https://github.com/eclipse-opensmartclide/smartclide-td-reusability-theia/pulls
• https://github.com/eclipse-opensmartclide/smartclide-service-creation-theia/pulls
• https://github.com/eclipse-opensmartclide/smartclide-service-creation/pulls
• https://github.com/eclipse-opensmartclide/smartclide-Service-Creation-Testing/pulls

Thank you a lot!

[reimer-atb]

Do you maybe know why the pull requests of this repo and the followings are stuck in the dependabot check?

I think the reason is that all repos require "checks" to succeed before PRs can be merged.

* https://github.com/eclipse-opensmartclide/smartclide-td-reusability-theia/pulls

* https://github.com/eclipse-opensmartclide/smartclide-service-creation-theia/pulls

These two don't have any checks to run. You would need to add a GH workflow that also runs on pull requests, I think. For example, a workflow that builds the project and runs the tests, like npm run build, npm run test, or similar.
See GH action docs for more examples.

* https://github.com/eclipse-opensmartclide/smartclide-service-creation/pulls

* https://github.com/eclipse-opensmartclide/smartclide-Service-Creation-Testing/pulls

These two have workflows defined but they are only triggered by pushes to the main branch:

on:
  push:
    branches: [ main ]

You could add an additional workflow that also runs on pull requests. For example, a workflow that builds the project and runs the tests (like mvn clean package), without publishing the image (because that might only be needed for things that have been approved and merged into the main branch).
See GH action docs

Hope that helps.

[nikosnikolaidis]

@philipreimer I know that these actions are missing but whatever I do, the checks cant complete.
Even if try to add the missing actions:

• Sonar Scanner folder removed and added in dockerfile #4 #16
• Create yarn.yml smartclide-service-creation-theia#27
• Create mavenBuild.yml smartclide-service-creation#13

or if I try to remove the github-action from dependabot:

• Fix dependabot smartclide-td-reusability-theia#19

or even delete the whole dependabot:

• Sonar Scanner folder removed and added in dockerfile #4 #16

I believe that it might require a force commit because the main is a protected branch. So it waits for the github action that cannot be committed with a regular pull request. But I cant say that I know a lot about this stuff so WDYT?

[reimer-atb]

I believe that it might require a force commit because the main is a protected branch. So it waits for the github action that cannot be committed with a regular pull request. But I cant say that I know a lot about this stuff so WDYT?

Force commits are not allowed, I believe. Sorry, I have no idea what the problem is.

Maybe @deanone has an idea? Otherwise, someone with admin rights will have to check the settings of these repositories. Which means we'll have to open a support request with eclipse.

[nikosnikolaidis]

@deanone @philipreimer,
Maybe we should open a support request with eclipse, to solve this issue.
All the information of the issue can be found in this pull request.

[reimer-atb]

@deanone @philipreimer, Maybe we should open a support request with eclipse, to solve this issue. All the information of the issue can be found in this pull request.

I just did.

[reimer-atb]

@nikosnikolaidis it appears that at least https://github.com/eclipse-opensmartclide/smartclide-service-creation-theia/pulls have been unblocked. Those PRs are just missing an approving review before they could be merged.

[nikosnikolaidis]

@philipreimer Yes indeed for that repo! But I don't know what caused it.

[reimer-atb]

Maybe the eclipse guys did something? It is not clear from their answer:

https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/2440#note_1058399

[deanone]

Dear all,

Even if someone with right access to the repo approves the changes, the PR is stuck to the dependabot check. And (maybe) because dependabot runs only at specific time every day, the PR is stuck until this time comes, the dependabot runs and hopefully the check passes.

However, is does not make sense to wait for almost a day for dependabot to run in order to pass a specific check. We should have a way to trigger the re-execution of such checks manually in cases like this. I already mentioned this to the issue.

Maybe we could try to re-initiate the execution of the checks by making an empty commit to the PR, as described at the first response here.