Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Calling conventions Doc #9720

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Add Calling conventions Doc #9720

merged 1 commit into from
Jun 12, 2020

Conversation

dsouzai
Copy link
Contributor

@dsouzai dsouzai commented May 27, 2020 •
edited
Loading

This information was only available internally; this PR adds it to the repo to aid with debugging.

Depends on eclipse-omr/omr#5254 (so I can add the link to it)

@dsouzai
Copy link
Contributor Author

dsouzai commented May 27, 2020

@fjeremic could you please review?

@knn-k could I bother you provide the arm/aarch64 version of this 🙂 ?

@knn-k
Copy link
Contributor

knn-k commented May 27, 2020

@dsouzai I am going to do that after this PR is merged.

@0xdaryl
Copy link
Contributor

0xdaryl commented May 28, 2020

Thanks for putting this together @dsouzai. It is a useful summary.

I feel that the system linkage summaries would best be documented in OMR as that is where the system linkages live and where developers on non-OpenJ9 projects have looked for them in the past. However, I do appreciate the convenience from a Java perspective of having the linkage descriptions all together. Perhaps you could move the system linkages to OMR, and provide a link in this document to that one in OMR?

@dsouzai
Copy link
Contributor Author

dsouzai commented May 28, 2020

Yeah sure, I have to fix up the formatting in this file any way, since I'm missing some |s in the right places.

@dsouzai dsouzai force-pushed the callingConventions branch from 93915d1 to 59a6de7 Compare May 28, 2020 15:31
@dsouzai dsouzai marked this pull request as draft May 28, 2020 15:31
@dsouzai dsouzai added the depends:omr Pull request is dependent on a corresponding change in OMR label May 28, 2020
@dsouzai dsouzai force-pushed the callingConventions branch from 59a6de7 to 0489903 Compare May 28, 2020 15:34
@dsouzai
Add Calling conventions Doc
5578c6d 
[ci skip]

Signed-off-by: Irwin D'Souza <[email protected]>
@dsouzai dsouzai force-pushed the callingConventions branch from 0489903 to 5578c6d Compare June 12, 2020 19:45
@dsouzai dsouzai marked this pull request as ready for review June 12, 2020 19:45
@dsouzai
Copy link
Contributor Author

dsouzai commented Jun 12, 2020

@fjeremic good for review now.

@fjeremic fjeremic self-assigned this Jun 12, 2020
@fjeremic
Copy link
Contributor

Looks good for a start. Happy to check this in an iterate upon it.

@fjeremic fjeremic merged commit a152777 into eclipse-openj9:master Jun 12, 2020
@knn-k
Copy link
Contributor

knn-k commented Jun 15, 2020 •
edited
Loading

I opened #9878 for 32-bit Arm and AArch64.

@dsouzai dsouzai deleted the callingConventions branch January 4, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjeremic fjeremic fjeremic approved these changes

Assignees

@fjeremic fjeremic

Labels
arch:power arch:x86 arch:z comp:doc comp:jit depends:omr Pull request is dependent on a corresponding change in OMR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dsouzai @knn-k @0xdaryl @fjeremic