Java 15 Use Unsafe.defineAnonyousClass() to define Hidden classes. #9485

hangshao0 · 2020-05-07T16:05:50Z

Add implementation of new Hidden class APIs to unblock the JDK15 builds.

Signed-off-by: Hang Shao [email protected]

[ci skip] Signed-off-by: Peter Shipton <[email protected]>

Related to 8242452: During module definition, move conversion of packages from native to VM The signature of JVM_DefineModule has been modified from `..., const char* const* packages, jsize numPackages` to `..., jobjectArray packages`. Also the package parameter of following has been modified from char* to jstring. JVM_AddModuleExports JVM_AddModuleExportsToAllUnnamed JVM_AddModuleExportsToAll Fixes eclipse-openj9#9293 Signed-off-by: Peter Shipton <[email protected]>

[ci skip] Signed-off-by: Peter Shipton <[email protected]>

hangshao0 · 2020-05-07T16:08:05Z

This PR is based on #9292. The last commit is my change. Other changes have already been review under #9292.

hangshao0 · 2020-05-07T16:08:20Z

Reviewer: @pshipton

hangshao0 · 2020-05-07T16:30:58Z

More change is required to resolve #9328. The change here is to unblock building of the latest jdk15.

jcl/src/java.base/share/classes/java/lang/invoke/MethodHandles.java

pshipton · 2020-05-07T18:29:23Z

jenkins test sanity zlinux jdknext depends ibmruntimes/openj9-openjdk-jdk#openj9-staging

pshipton · 2020-05-07T18:31:38Z

Set as WIP since when this is merged, the jdk openj9-staging branch also needs to be promoted. We'll need to run a full acceptance build first.

I should also mention that openj9-staging is typically updated every night, so this is a moving target. Although we can promote the SHA that was validated.

keithc-ca · 2020-05-07T20:17:52Z

jenkins test sanity zlinux jdknext depends ibmruntimes/openj9-openjdk-jdk#openj9-staging

~~That didn't work: it built openj9 instead of openj9-staging.~~ Oops, looking at the wrong part of the log.

AdamBrousseau · 2020-05-07T20:38:58Z

The trigger is open enough that any type of text/code/quoting jenkins followed by compile or test will trigger a build.

keithc-ca · 2020-05-07T20:47:54Z

This error is unexpected:

[2020-05-07T18:42:21.333Z] /home/jenkins/workspace/Build_JDKnext_s390x_linux_Personal/openj9/debugtools/DDR_VM/src/com/ibm/j9ddr/view/dtfj/image/J9DDRImage.java:336: error: method does not override or implement a method from a supertype
[2020-05-07T18:42:21.333Z] 	@Override
[2020-05-07T18:42:21.333Z] 	^

I'll investigate.

pshipton · 2020-05-07T20:48:48Z

The build error is the following which I think we've seen before. @keithc-ca are you going to fix this one?

/home/jenkins/workspace/Build_JDKnext_s390x_linux_Personal/openj9/debugtools/DDR_VM/src/com/ibm/j9ddr/view/dtfj/image/J9DDRImage.java:336: error: method does not override or implement a method from a supertype
 	@Override

keithc-ca · 2020-05-07T21:26:46Z

It's unclear how that could happen. The DDR.gmk makefile is being executed for the openj9.dtfj-ddr-jar target which depends upon openj9.dtfj-ddr-gen which in turn depends on openj9.dtfj-java: when openj9.dtfj-java has completed we should expect the class files for that module to be available.

The previous problem was due to improper javac options, but that has been fixed: see ibmruntimes/openj9-openjdk-jdk#199.

keithc-ca · 2020-05-11T20:51:51Z

Jenkins test sanity zlinux jdknext depends ibmruntimes/openj9-openjdk-jdk#openj9-staging

keithc-ca · 2020-05-12T00:41:14Z

Jenkins test sanity zlinux jdknext depends keithc-ca/openj9-openjdk#makefiles

pshipton · 2020-05-12T00:51:53Z

Jenkins test sanity zlinux jdknext depends keithc-ca/openj9-openjdk-jdk#makefiles

keithc-ca · 2020-05-12T00:53:10Z

That incantation doesn't appear to work: I think it needs to reference a pull request (instead of a branch in some random repository).

pshipton · 2020-05-12T00:54:35Z

That incantation doesn't appear to work: I think it needs to reference a pull request (instead of a branch in some random repository).

The one you started had the wrong repo name, openj9-openjdk instead of openj9-openjdk-jdk

pshipton · 2020-05-12T00:55:47Z

The machines are offline for a short while for sanitizing, the job is waiting on a machine. We'll see if it works in a bit.

keithc-ca · 2020-05-12T02:40:07Z

The one you started had the wrong repo name, openj9-openjdk instead of openj9-openjdk-jdk

No, that is the name I use for that repo (I omit the -jdk segment).

pshipton · 2020-05-12T02:52:18Z

Jenkins test sanity zlinux jdknext depends ibmruntimes/openj9-openjdk-jdk#openj9-staging

runtime/j9vm/java11vmi.c

DanHeidinga

lgtm

DanHeidinga · 2020-05-20T17:09:02Z

Jenkins test sanity aix,zlinux,win jdknext depends ibmruntimes/openj9-openjdk-jdk#openj9-staging

DanHeidinga · 2020-05-20T17:09:30Z

Running testing on a limited subset of platforms to catch any compiler errors given previous test runs were largely clean

pshipton · 2020-05-20T18:32:00Z

@DanHeidinga note that ibmruntimes/openj9-openjdk-jdk#openj9-staging is a moving target, it's typically updated every night. We should do a full run of the platforms*, and then merge this and promote openj9-staging before it gets updated in the nightly merge from OpenJDK. Otherwise, the tested openj9-staging sha can be promoted manually, which hopefully is just a push if no additional jdknext PRs get merged in the meantime.

the subset of platforms tested by the acceptance build are:
ppc64_aix,x86-64_linux,x86-64_linux_xl,x86-64_linux_cm,ppc64le_linux,s390x_linux,x86-64_windows,x86-64_mac

pshipton · 2020-05-20T18:33:40Z

The AIX failure is

14:23:59  /home/jenkins/workspace/Build_JDKnext_ppc64_aix_Personal/build/aix-ppc64-server-release/support/j9jcl_sources/java.base/share/classes/java/lang/Access.java:61: error: Access is not abstract and does not override abstract method stringConcatInitialCoder() in JavaLangAccess
14:23:59  final class Access implements JavaLangAccess {
14:23:59        ^

pshipton · 2020-05-20T18:34:37Z

@hangshao0 can you please stub the new method so we can re-test.

hangshao0 · 2020-05-20T19:59:54Z

can you please stub the new method so we can re-test.

Done.

runtime/j9vm/java11vmi.c

keithc-ca · 2020-05-20T23:35:37Z

Jenkins test sanity aix,osx,plinux,win,xlinux,xlinuxcm,xlinuxxl,zlinux jdknext depends ibmruntimes/openj9-openjdk-jdk#openj9-staging

pshipton · 2020-05-20T23:43:00Z

Jenkins test sanity aix,zlinux,win,osx jdknext depends ibmruntimes/openj9-openjdk-jdk#openj9-staging

pshipton · 2020-05-20T23:44:31Z

sorry @keithc-ca, for some reason I didn't see your PR build before I started mine. I stopped mine, yours is still running https://ci.eclipse.org/openj9/job/PullRequest-OpenJ9/3621/

pshipton · 2020-05-21T14:27:45Z

@hangshao0 pls fix the commit title for "Add Javadoc to ClassOption and defineHiddenClass()". This title is misleading since the commit doesn't only add javadoc changes.

hangshao0 · 2020-05-21T15:25:42Z

Added more info into the title.

keithc-ca · 2020-05-21T16:38:18Z

@hangshao0 Can you please update the commit comment again?
The first line should be no more than 70 characters and the second line should be blank:
see https://github.com/eclipse/openj9/blob/master/CONTRIBUTING.md.

1. Use copyStringToUTF8Helper() to copy and covert packageName 2. Add Javadoc to ClassOption and defineHiddenClass(). 3. Add implementation of stringConcatInitialCoder() in Access.java issue eclipse-openj9#9328 Signed-off-by: Hang Shao <[email protected]>

hangshao0 · 2020-05-21T18:01:01Z

Can you please update the commit comment again?

Done.

keithc-ca · 2020-05-21T18:08:19Z

Jenkins test sanity aix,osx,win,win32,zlinux jdk8

keithc-ca · 2020-05-21T18:09:00Z

Jenkins test sanity aix,osx,plinux,win jdk11

pshipton added 3 commits May 6, 2020 14:26

Java 15 BufferPool class has moved to a different package

d67743b

[ci skip] Signed-off-by: Peter Shipton <[email protected]>

Java 15 - stub in hidden class support

779f063

[ci skip] Signed-off-by: Peter Shipton <[email protected]>

keithc-ca reviewed May 7, 2020

View reviewed changes

jcl/src/java.base/share/classes/java/lang/invoke/MethodHandles.java Outdated Show resolved Hide resolved

jcl/src/java.base/share/classes/java/lang/invoke/MethodHandles.java Outdated Show resolved Hide resolved

keithc-ca reviewed May 7, 2020

View reviewed changes

jcl/src/java.base/share/classes/java/lang/invoke/MethodHandles.java Outdated Show resolved Hide resolved

hangshao0 force-pushed the JEP371_Test branch from 171e366 to d819802 Compare May 7, 2020 18:11

pshipton reviewed May 7, 2020

View reviewed changes

jcl/src/java.base/share/classes/java/lang/invoke/MethodHandles.java Show resolved Hide resolved

pshipton requested a review from DanHeidinga May 7, 2020 18:26

pshipton added the comp:vm label May 7, 2020

pshipton changed the title ~~Use Unsafe.defineAnonyousClass() to define Hidden classes.~~ Java 15 Use Unsafe.defineAnonyousClass() to define Hidden classes. May 7, 2020

pshipton changed the title ~~Java 15 Use Unsafe.defineAnonyousClass() to define Hidden classes.~~ WIP Java 15 Use Unsafe.defineAnonyousClass() to define Hidden classes. May 7, 2020

keithc-ca mentioned this pull request May 12, 2020

Update makefiles for recent openjdk changes (part 2) ibmruntimes/openj9-openjdk-jdk#206

Merged

hangshao0 force-pushed the JEP371_Test branch from c7af481 to ce8f59b Compare May 14, 2020 22:32

DanHeidinga reviewed May 20, 2020

View reviewed changes

hangshao0 force-pushed the JEP371_Test branch from ce8f59b to 7cd85a9 Compare May 20, 2020 15:37

DanHeidinga approved these changes May 20, 2020

View reviewed changes

hangshao0 force-pushed the JEP371_Test branch from 7cd85a9 to 2797295 Compare May 20, 2020 19:55

keithc-ca requested changes May 20, 2020

View reviewed changes

runtime/j9vm/java11vmi.c Outdated Show resolved Hide resolved

hangshao0 force-pushed the JEP371_Test branch from 2797295 to f656f57 Compare May 20, 2020 21:13

keithc-ca approved these changes May 20, 2020

View reviewed changes

hangshao0 force-pushed the JEP371_Test branch from f656f57 to 34cde16 Compare May 21, 2020 15:24

hangshao0 force-pushed the JEP371_Test branch from 34cde16 to 7f8ae5a Compare May 21, 2020 17:56

pshipton approved these changes May 21, 2020

View reviewed changes

keithc-ca merged commit b1a5855 into eclipse-openj9:master May 21, 2020

This was referenced May 21, 2020

jdk15: build error: JavaNioAccess.BufferPool symbol not found #9278

Closed

jdk15 build crash in JVM_DefineModule #9293

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Java 15 Use Unsafe.defineAnonyousClass() to define Hidden classes. #9485

Java 15 Use Unsafe.defineAnonyousClass() to define Hidden classes. #9485

hangshao0 commented May 7, 2020

hangshao0 commented May 7, 2020

hangshao0 commented May 7, 2020

hangshao0 commented May 7, 2020

pshipton commented May 7, 2020

pshipton commented May 7, 2020 •

edited

Loading

keithc-ca commented May 7, 2020 •

edited

Loading

AdamBrousseau commented May 7, 2020

keithc-ca commented May 7, 2020

pshipton commented May 7, 2020 •

edited

Loading

keithc-ca commented May 7, 2020 •

edited

Loading

keithc-ca commented May 11, 2020

keithc-ca commented May 12, 2020

pshipton commented May 12, 2020

keithc-ca commented May 12, 2020

pshipton commented May 12, 2020

pshipton commented May 12, 2020

keithc-ca commented May 12, 2020

pshipton commented May 12, 2020

DanHeidinga left a comment

DanHeidinga commented May 20, 2020

DanHeidinga commented May 20, 2020

pshipton commented May 20, 2020

pshipton commented May 20, 2020

pshipton commented May 20, 2020

hangshao0 commented May 20, 2020

keithc-ca commented May 20, 2020

pshipton commented May 20, 2020

pshipton commented May 20, 2020 •

edited

Loading

pshipton commented May 21, 2020

hangshao0 commented May 21, 2020 •

edited

Loading

keithc-ca commented May 21, 2020

hangshao0 commented May 21, 2020

keithc-ca commented May 21, 2020

keithc-ca commented May 21, 2020

Java 15 Use Unsafe.defineAnonyousClass() to define Hidden classes. #9485

Java 15 Use Unsafe.defineAnonyousClass() to define Hidden classes. #9485

Conversation

hangshao0 commented May 7, 2020

hangshao0 commented May 7, 2020

hangshao0 commented May 7, 2020

hangshao0 commented May 7, 2020

pshipton commented May 7, 2020

pshipton commented May 7, 2020 • edited Loading

keithc-ca commented May 7, 2020 • edited Loading

AdamBrousseau commented May 7, 2020

keithc-ca commented May 7, 2020

pshipton commented May 7, 2020 • edited Loading

keithc-ca commented May 7, 2020 • edited Loading

keithc-ca commented May 11, 2020

keithc-ca commented May 12, 2020

pshipton commented May 12, 2020

keithc-ca commented May 12, 2020

pshipton commented May 12, 2020

pshipton commented May 12, 2020

keithc-ca commented May 12, 2020

pshipton commented May 12, 2020

DanHeidinga left a comment

Choose a reason for hiding this comment

DanHeidinga commented May 20, 2020

DanHeidinga commented May 20, 2020

pshipton commented May 20, 2020

pshipton commented May 20, 2020

pshipton commented May 20, 2020

hangshao0 commented May 20, 2020

keithc-ca commented May 20, 2020

pshipton commented May 20, 2020

pshipton commented May 20, 2020 • edited Loading

pshipton commented May 21, 2020

hangshao0 commented May 21, 2020 • edited Loading

keithc-ca commented May 21, 2020

hangshao0 commented May 21, 2020

keithc-ca commented May 21, 2020

keithc-ca commented May 21, 2020

pshipton commented May 7, 2020 •

edited

Loading

keithc-ca commented May 7, 2020 •

edited

Loading

pshipton commented May 7, 2020 •

edited

Loading

keithc-ca commented May 7, 2020 •

edited

Loading

pshipton commented May 20, 2020 •

edited

Loading

hangshao0 commented May 21, 2020 •

edited

Loading