Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UMA: Add ability to override flags from command line #78

Merged
merged 1 commit into from
Sep 21, 2017

Conversation

dnakamura
Copy link
Contributor

Add ability to set/unset flags from the command line when invoking uma,
without having to modify the relevant buildspec file.

Signed-off-by: Devin Nakamura [email protected]

Add ability to set/unset flags from the command line when invoking uma,
without having to modify the relevant buildspec file.

Signed-off-by: Devin Nakamura <[email protected]>
Copy link
Contributor

@rservant rservant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to UMA look good.

@DanHeidinga
Copy link
Member

This is a cool hack @dnakamura! Can you provide some additional rationale for this change?

As you're well aware, UMA is something we'd like to replace with CMAKE. Is this something to ease the transition from UMA to CMAKE?

@dnakamura
Copy link
Contributor Author

Yes this is really to make life easier during the transition period. Currently I have cmake build run conditionally on the presence of the build_cmake flag, which needs to be set in the appropriate buildspec file. This means i need to maintain a long running branch which keeps the modified buildspec (which we obviously don't want to merge until cmake is ready for prime time).

In addition the openj9-openjdk-jdk9 build scripts need to take a different approach when building a cmake enabled build vs a non-cmake eanabled build. However there is no infrastructure there for parsing out the buildspecs, so it makes it much more difficult to enable the conditional behavior. Rather than have to pull that information up into the build/configure scripts, it seemed much easier to push it down into uma, overriding values in the build spec. The next step is to add an option to the configure script, --with-cmake. The presence/absence of this flag determines if uma is called with -D build_cmake or -U build_cmake respectively. This allows the cmake changes to live side by side with the current build system in master, and would allow anyone to test them without having to apply any patches to the repo

@DanHeidinga
Copy link
Member

Thanks @dnakamura. Can you open a longer running issue to track the work / document the plan for the transition from UMA to cmake and link this PR from the issue?

@genie-openj9
Copy link

Can one of the admins verify this patch?

@pshipton pshipton self-requested a review September 20, 2017 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants