-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UMA: Add ability to override flags from command line #78
Conversation
Add ability to set/unset flags from the command line when invoking uma, without having to modify the relevant buildspec file. Signed-off-by: Devin Nakamura <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to UMA look good.
This is a cool hack @dnakamura! Can you provide some additional rationale for this change? As you're well aware, UMA is something we'd like to replace with CMAKE. Is this something to ease the transition from UMA to CMAKE? |
Yes this is really to make life easier during the transition period. Currently I have cmake build run conditionally on the presence of the In addition the |
Thanks @dnakamura. Can you open a longer running issue to track the work / document the plan for the transition from UMA to cmake and link this PR from the issue? |
Can one of the admins verify this patch? |
Add ability to set/unset flags from the command line when invoking uma,
without having to modify the relevant buildspec file.
Signed-off-by: Devin Nakamura [email protected]