Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port cmdLineTester_lockWordAlignment_Object_* tests #7305

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Port cmdLineTester_lockWordAlignment_Object_* tests #7305

merged 1 commit into from
Oct 8, 2019

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Oct 1, 2019 •
edited
Loading

  • port cmdLineTester_lockWordAlignment_Object_* tests (NonStandard)
  • create ADD_EXPORTS and ASM_JAR macro so that we can merge tests for JDK8 and
    JDK9+ into one

[ci skip]

Signed-off-by: lanxia [email protected]

@llxia llxia added the comp:test label Oct 1, 2019
@llxia
Copy link
Contributor Author

llxia commented Oct 1, 2019

jenkins test extended all jdk8,jdk11

@llxia llxia force-pushed the test10 branch 4 times, most recently from 8046d6d to 0a18869 Compare October 2, 2019 19:27
@llxia
Port cmdLineTester_lockWordAlignment_Object_* tests
2808725 
- port cmdLineTester_lockWordAlignment_Object_* tests (NonStandard)
- create `ADD_EXPORTS` and `ASM_JAR` macro so that we can merge tests
for JDK8 and
JDK9+ into one

[ci skip]

Signed-off-by: lanxia <[email protected]>
@llxia
Copy link
Contributor Author

llxia commented Oct 2, 2019

jenkins test extended all jdk8,jdk11

@llxia
Copy link
Contributor Author

llxia commented Oct 3, 2019 •
edited
Loading

TestAttachErrorHandling_0 failure on AIX is related to #3081

19:05:07  [AttachApiTest] [ERROR] com.sun.tools.attach.AttachNotSupportedException: acknowledgement timeout from 11272294 on port 36214
19:05:07  	at jdk.attach/com.ibm.tools.attach.attacher.OpenJ9VirtualMachine.tryAttachTarget(OpenJ9VirtualMachine.java:482)
19:05:07  	at jdk.attach/com.ibm.tools.attach.attacher.OpenJ9VirtualMachine.attachTargetImpl(OpenJ9VirtualMachine.java:157)

@llxia llxia marked this pull request as ready for review October 3, 2019 12:16
@llxia llxia requested a review from smlambert October 3, 2019 12:17
smlambert
smlambert approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @llxia !

@smlambert
Copy link
Contributor

as per #7305 (comment), proceed to merge as AIX test failure known & separate from this PR...

@smlambert smlambert merged commit fd8cd8f into eclipse-openj9:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlambert smlambert smlambert approved these changes

Assignees
No one assigned
Labels
comp:test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@llxia @smlambert