Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced JAVA_BIN in openj9 #6548

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Replaced JAVA_BIN in openj9 #6548

merged 1 commit into from
Jul 30, 2019

Conversation

LongyuZhang
Copy link
Contributor

  • replaced JAVA_BIN in openj9 test
    [ci skip]

Signed-off-by: Longyu Zhang [email protected]

@LongyuZhang
Copy link
Contributor Author

reviewers: @llxia @renfeiw

llxia
llxia reviewed Jul 23, 2019
View reviewed changes
test/TestConfig/scripts/build_test.xml Outdated
@@ -101,7 +100,7 @@


<target name="check_sdk">
<available file="${JAVA_BIN}" property="sdk.present" />
<available file="${TEST_JDK_HOME}" property="sdk.present" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think check_sdk target can be removed.

renfeiw
renfeiw approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@renfeiw renfeiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia
Copy link
Contributor

llxia commented Jul 24, 2019

This PR cannot be merged until the internal reference to check_sdk target is removed.

@llxia
Copy link
Contributor

llxia commented Jul 24, 2019

jenkins test sanity,extended all jdk8

@llxia
Copy link
Contributor

llxia commented Jul 25, 2019

TestAttachErrorHandling_SE80_0 failure in https://ci.eclipse.org/openj9/job/Test_openjdk8_j9_extended.functional_ppc64_aix_Personal/29/ is the same as #3081

00:43:46.729  FAILED: test_startupShutdownRobustness
00:43:46.729  java.lang.AssertionError: target 17105066: wait loop not terminated
00:43:46.729  	at org.testng.AssertJUnit.fail(AssertJUnit.java:59)
00:43:46.729  	at org.testng.AssertJUnit.assertTrue(AssertJUnit.java:24)
00:43:46.729  	at org.testng.AssertJUnit.assertFalse(AssertJUnit.java:41)

@llxia
Copy link
Contributor

llxia commented Jul 25, 2019

jenkins test sanity,extended all jdk11

@LongyuZhang
Replaced JAVA_BIN in openj9
ef92206 
- replaced JAVA_BIN in openj9 test
[ci skip]

Signed-off-by: Longyu Zhang <[email protected]>
@llxia
Copy link
Contributor

llxia commented Jul 25, 2019

jenkins test sanity,extended all jdk11

llxia
llxia approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia merged commit b009372 into eclipse-openj9:master Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llxia llxia llxia approved these changes

@renfeiw renfeiw renfeiw approved these changes

Assignees
No one assigned
Labels
comp:test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LongyuZhang @llxia @renfeiw