Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary files for building JitBuilder #616

Merged

Conversation

rbanerjee
Copy link
Contributor

While building JitBuilder on OS/X, the archiver warns about
files which it believes to be responsible for generating empty
objects.

Upon closer inspection, that indeed seems to be the case.

The actual files are being removed in eclipse-omr/omr#1740
This commit acts as a paired dependency change on the OpenJ9 side.

Signed-off-by: Rwitaban (Ray) Banerjee [email protected]

@rbanerjee
Copy link
Contributor Author

@0xdaryl ptal. This must be merged before eclipse-omr/omr#1740 can go through.

@rbanerjee rbanerjee changed the title Remove unnecessary files for building JitBuilder WIP: Remove unnecessary files for building JitBuilder Nov 17, 2017
@rbanerjee
Copy link
Contributor Author

rbanerjee commented Nov 17, 2017

Not to be merged. Something seems to have gone wrong. Marking this WIP.

@rbanerjee rbanerjee force-pushed the remove_unused_files_in_codegen branch from 392466c to ddc0d21 Compare November 17, 2017 17:03
@rbanerjee
Copy link
Contributor Author

rbanerjee commented Nov 17, 2017

In the last patch-set, I deleted a few more files than necessary but for some reason Travis didn't seem to complain.
A little embarrassing, but at least we have got a nice Issue out of it now 😁 #618

@0xdaryl Should be good. Removing the WIP tag.

@rbanerjee rbanerjee changed the title WIP: Remove unnecessary files for building JitBuilder Remove unnecessary files for building JitBuilder Nov 17, 2017
@fjeremic fjeremic self-assigned this Nov 21, 2017
@fjeremic
Copy link
Contributor

Jenkins test sanity

@fjeremic
Copy link
Contributor

@rbanerjee we'll need a rebase here.

While building JitBuilder on OS/X, the archiver warns about
files which it believes to be responsible for generating empty
objects.

Upon closer inspection, that indeed seems to be the case.

The actual files are being removed in eclipse-omr/omr/pull/1740.
This commit acts as a paired dependency change on the OpenJ9 side.

Signed-off-by: Rwitaban (Ray) Banerjee <[email protected]>
@rbanerjee rbanerjee force-pushed the remove_unused_files_in_codegen branch from ddc0d21 to fa00abe Compare November 23, 2017 23:00
@rbanerjee
Copy link
Contributor Author

@fjeremic Done.

@fjeremic
Copy link
Contributor

Jenkins test sanity

@fjeremic fjeremic merged commit 3e73b2d into eclipse-openj9:master Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants