-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary files for building JitBuilder #616
Merged
fjeremic
merged 1 commit into
eclipse-openj9:master
from
rbanerjee:remove_unused_files_in_codegen
Nov 24, 2017
Merged
Remove unnecessary files for building JitBuilder #616
fjeremic
merged 1 commit into
eclipse-openj9:master
from
rbanerjee:remove_unused_files_in_codegen
Nov 24, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@0xdaryl ptal. This must be merged before eclipse-omr/omr#1740 can go through. |
rbanerjee
changed the title
Remove unnecessary files for building JitBuilder
WIP: Remove unnecessary files for building JitBuilder
Nov 17, 2017
|
rbanerjee
force-pushed
the
remove_unused_files_in_codegen
branch
from
November 17, 2017 17:03
392466c
to
ddc0d21
Compare
rbanerjee
changed the title
WIP: Remove unnecessary files for building JitBuilder
Remove unnecessary files for building JitBuilder
Nov 17, 2017
fjeremic
approved these changes
Nov 21, 2017
Jenkins test sanity |
@rbanerjee we'll need a rebase here. |
While building JitBuilder on OS/X, the archiver warns about files which it believes to be responsible for generating empty objects. Upon closer inspection, that indeed seems to be the case. The actual files are being removed in eclipse-omr/omr/pull/1740. This commit acts as a paired dependency change on the OpenJ9 side. Signed-off-by: Rwitaban (Ray) Banerjee <[email protected]>
rbanerjee
force-pushed
the
remove_unused_files_in_codegen
branch
from
November 23, 2017 23:00
ddc0d21
to
fa00abe
Compare
@fjeremic Done. |
Jenkins test sanity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While building JitBuilder on OS/X, the archiver warns about
files which it believes to be responsible for generating empty
objects.
Upon closer inspection, that indeed seems to be the case.
The actual files are being removed in eclipse-omr/omr#1740
This commit acts as a paired dependency change on the OpenJ9 side.
Signed-off-by: Rwitaban (Ray) Banerjee [email protected]