Update the configuration files for testing against non-openj9 SDK #6001

dutingda · 2019-06-03T20:59:48Z

Updating build.xml to make compilation part work for non-openj9 SDK
Updating playlist.xml to restrict several tests to only openj9 SDK

[ci skip]

Signed-off-by: Tingda Du [email protected]

dutingda · 2019-06-03T21:00:02Z

@renfeiw @llxia @smlambert Please review thanks!

smlambert · 2019-06-03T21:42:01Z

Thanks @dutingda - please see https://github.com/eclipse/openj9/blob/master/CONTRIBUTING.md#legal-considerations for instructions on signing the ECA (Eclipse Contributors Agreement) which will need to be done before your contribution would be merged.

smlambert · 2019-06-03T21:43:13Z

test/functional/cmdLineTests/build.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0"?>

 <!--
-  Copyright (c) 2016, 2018 IBM Corp. and others
+  Copyright (c) 2016, 2018, 2019 IBM Corp. and others


change to
Copyright (c) 2016, 2019 IBM Corp. and others

Have fixed thanks

renfeiw · 2019-06-04T20:37:01Z

test/functional/DDR_Test/build.xml

 			</then>
 		</if>
 	</target>
 </project>
+
+
+


Please remove the extra spaces.

renfeiw · 2019-06-04T20:38:26Z

test/functional/JLM_Tests/build.xml

+      <then>
+        <antcall target="clean" inheritall="true" />
+      </then>
+    </if>


Please fix the indentation.

indentation is not fixed.

renfeiw · 2019-06-04T20:38:40Z

test/functional/Java8andUp/build.xml

+      <then>
+        <antcall target="clean" inheritall="true" />
+      </then>
+    </if>


Please fix the indentation.

indentation is not fixed.

renfeiw · 2019-06-04T20:38:56Z

test/functional/JavaAgentTest/build.xml

+            <then>
+            	<antcall target="clean" inheritall="true" />
+             </then>
+       </if>


Please fix the indentation.

renfeiw · 2019-06-04T20:39:07Z

test/functional/UnsafeTest/build.xml

+					</then>
+				</if>
+             </then>
+       </if>


Please fix the indentation.

renfeiw · 2019-06-04T20:39:17Z

test/functional/VM_Test/build.xml

+            <then>
+            	<antcall target="clean" inheritall="true" />
+             </then>
+       </if>


Please fix the indentation.

renfeiw · 2019-06-04T20:39:24Z

test/functional/cmdLineTests/build.xml

+					</else>
+				</if>			
+             </then>
+       </if>	


Please fix the indentation.

smlambert · 2019-06-06T19:41:10Z

Please let me know when ready for re-review, you also will need to fix the merge conflict.

llxia

Please fix all the indentation issue in the changeset. I did not list all of them.

llxia · 2019-06-18T16:11:26Z

test/functional/cmdLineTests/jvmtitests/build.xml

+      		<then>
+        		<antcall target="clean" inheritall="true" />
+      		</then>
+    	</if>


Please fix the indentation.

llxia · 2019-06-18T16:13:53Z

test/functional/cmdLineTests/pageAlignDirectMemory/playlist.xml

+    <impls>
+			<impl>openj9</impl>
+			<impl>ibm</impl>
+		</impls>


Please fix the indentation.

llxia · 2019-06-18T16:14:02Z

test/functional/cmdLineTests/shareClassTests/DataHelperTests/build.xml

+      		<then>
+        		<antcall target="clean" inheritall="true" />
+      		</then>
+    	</if>


Please fix the indentation.

llxia · 2019-06-18T16:14:16Z

test/functional/cmdLineTests/shareClassTests/SCHelperCompatibilityTests/build.xml

+      		<then>
+        		<antcall target="clean" inheritall="true" />
+      		</then>
+    	</if>


Please fix the indentation.

llxia · 2019-06-18T19:50:42Z

Still have error Unrecognized option...

https://ci.eclipse.org/openj9/view/Test/job/Test-Grinder/411/tapResults/

llxia · 2019-07-03T16:59:57Z

Please rebase and fix the merge conflict. Thanks.

llxia · 2019-07-03T17:51:37Z

Please update the title and description to be more meaningful and fix grammar errors.
For example, the title could be Update the configuration files for testing against non-openj9 SDK

llxia · 2019-07-03T18:21:58Z

Please also update the description/commit msg to fix the grammar errors

llxia · 2019-07-03T18:23:59Z

Please fix the Unrecognized option error:
https://ci.eclipse.org/openj9/view/Test/job/Test-Grinder/425/tapResults/

llxia · 2019-07-03T19:35:54Z

Failure in sanity.functional in JDK11 hotspot.
https://ci.eclipse.org/openj9/view/Test/job/Test-Grinder/428/tapResults/

llxia · 2019-07-03T19:46:30Z

test/functional/DDR_Test/build.xml

@@ -99,12 +100,21 @@ SPDX-License-Identifier: EPL-2.0 OR Apache-2.0 OR GPL-2.0 WITH Classpath-excepti
 	<!-- Temporarily disable compilation on zos until ddr is supported; github.com/eclipse/openj9/issues/1511 -->
 	<target name="build" >
 		<echo>os.name: ${os.name}</echo>
+		<echo>impl: ${JDK_IMPL}</echo>


Please remove the echo msg.

llxia · 2019-07-04T21:08:56Z

https://ci.eclipse.org/openj9/view/Test/job/Test-Grinder/445/
https://ci.eclipse.org/openj9/view/Test/job/Test-Grinder/444/

llxia · 2019-07-04T21:10:03Z

jenkins test sanity,extended all jdk11

llxia · 2019-07-05T13:52:55Z

Please fix the errors in PR builds.

00:28:18.194  /home/u0020236/workspace1/Test_openjdk11_j9_extended.functional_ppc64_aix_Personal/openjdk-tests/functional/cmdLineTests/stackSizeInfoTest/build.xml:49: The following error occurred while executing this line:
00:28:18.194  Target "clean" does not exist in the project "cmdLineTests".

- Updating build.xml to make compilation part work for non-openj9 SDK - Updating playlist.xml to restrict several tests to only openj9 SDK [ci skip] Signed-off-by: Tingda Du <[email protected]>

llxia · 2019-07-08T20:23:13Z

jenkins test sanity,extended all jdk11

llxia · 2019-07-09T14:18:46Z

jenkins test sanity,extended all jdk8

llxia · 2019-07-09T20:07:47Z

AIX builds failure are related to #4643 and #3081

llxia

LGTM

dutingda force-pushed the master branch from f293b2a to 5d9b8bb Compare June 3, 2019 21:06

smlambert reviewed Jun 3, 2019

View reviewed changes

dutingda force-pushed the master branch 10 times, most recently from a782e95 to d538189 Compare June 4, 2019 19:53

renfeiw reviewed Jun 4, 2019

View reviewed changes

dutingda force-pushed the master branch 2 times, most recently from e725367 to 8b145c7 Compare June 5, 2019 15:49

smlambert added the comp:test label Jun 5, 2019

dutingda force-pushed the master branch from 8b145c7 to 882aa49 Compare June 5, 2019 19:09

dutingda force-pushed the master branch 4 times, most recently from 0b33cd8 to 62e39cb Compare June 6, 2019 20:35

smlambert mentioned this pull request Jun 7, 2019

Identify initial set of test targets for AQA v1.0 (July release) adoptium/aqa-tests#1166

Closed

dutingda force-pushed the master branch 5 times, most recently from 216b13c to 484eecf Compare June 13, 2019 22:40

llxia reviewed Jun 18, 2019

View reviewed changes

dutingda force-pushed the master branch 2 times, most recently from ef70479 to 7eb4c3e Compare June 18, 2019 17:59

dutingda force-pushed the master branch 3 times, most recently from f171980 to d34f233 Compare June 19, 2019 16:20

dutingda force-pushed the master branch from d34f233 to b4c0120 Compare July 3, 2019 17:21

dutingda force-pushed the master branch from b4c0120 to e561547 Compare July 3, 2019 17:54

dutingda changed the title ~~Modified several configuration files for ant building for hotspot~~ Update the configuration files for testing against non-openj9 SDK Jul 3, 2019

dutingda force-pushed the master branch from e561547 to a57721b Compare July 3, 2019 18:48

llxia reviewed Jul 3, 2019

View reviewed changes

dutingda force-pushed the master branch 2 times, most recently from f102ab3 to 4016cac Compare July 4, 2019 20:32

Update the configuration files for testing against non-openj9 SDK

6c2ae6e

- Updating build.xml to make compilation part work for non-openj9 SDK - Updating playlist.xml to restrict several tests to only openj9 SDK [ci skip] Signed-off-by: Tingda Du <[email protected]>

dutingda force-pushed the master branch from 4016cac to 6c2ae6e Compare July 5, 2019 14:22

llxia approved these changes Jul 9, 2019

View reviewed changes

llxia merged commit eb860ec into eclipse-openj9:master Jul 9, 2019

llxia mentioned this pull request Jul 9, 2019

Some functional tests don't compile on non-openj9 JVMs #4131

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the configuration files for testing against non-openj9 SDK #6001

Update the configuration files for testing against non-openj9 SDK #6001

dutingda commented Jun 3, 2019 •

edited

Loading

dutingda commented Jun 3, 2019 •

edited

Loading

smlambert commented Jun 3, 2019

smlambert Jun 3, 2019

dutingda Jun 3, 2019

renfeiw Jun 4, 2019

renfeiw Jun 4, 2019

llxia Jun 17, 2019

renfeiw Jun 4, 2019

llxia Jun 17, 2019

renfeiw Jun 4, 2019

renfeiw Jun 4, 2019

renfeiw Jun 4, 2019

renfeiw Jun 4, 2019

smlambert commented Jun 6, 2019

llxia left a comment

llxia Jun 18, 2019

llxia Jun 18, 2019

llxia Jun 18, 2019

llxia Jun 18, 2019

llxia commented Jun 18, 2019

llxia commented Jul 3, 2019

llxia commented Jul 3, 2019

llxia commented Jul 3, 2019

llxia commented Jul 3, 2019

llxia commented Jul 3, 2019

llxia Jul 3, 2019

llxia commented Jul 4, 2019

llxia commented Jul 4, 2019

llxia commented Jul 5, 2019

llxia commented Jul 8, 2019

llxia commented Jul 9, 2019

llxia commented Jul 9, 2019

llxia left a comment

Update the configuration files for testing against non-openj9 SDK #6001

Update the configuration files for testing against non-openj9 SDK #6001

Conversation

dutingda commented Jun 3, 2019 • edited Loading

dutingda commented Jun 3, 2019 • edited Loading

smlambert commented Jun 3, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smlambert commented Jun 6, 2019

llxia left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

llxia commented Jun 18, 2019

llxia commented Jul 3, 2019

llxia commented Jul 3, 2019

llxia commented Jul 3, 2019

llxia commented Jul 3, 2019

llxia commented Jul 3, 2019

Choose a reason for hiding this comment

llxia commented Jul 4, 2019

llxia commented Jul 4, 2019

llxia commented Jul 5, 2019

llxia commented Jul 8, 2019

llxia commented Jul 9, 2019

llxia commented Jul 9, 2019

llxia left a comment

Choose a reason for hiding this comment

dutingda commented Jun 3, 2019 •

edited

Loading

dutingda commented Jun 3, 2019 •

edited

Loading