Relocate OMR::SupportsBigDecimalLongLookasideVersioning to OpenJ9 #5839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xdaryl
requested changes
May 22, 2019
The OMR::CodeGenerator class defines functionsgetSupportsBigDecimalLongLookasideVersioning and setSupportsBigDecimalLongLookasideVersioning that are not used in OMR. They only have relevance in OpenJ9 and should be relocated to the J9::CodeGenerator class there. Issue: eclipse-omr/omr#1882 Signed-off-by: Bohao(Aaron) Wang <[email protected]>
wbh123456
force-pushed
the
MoveGetSupportsFunctions
branch
from
27ed276 to
8fcab29
Compare
|
Jenkins test sanity all jdk11 |
0xdaryl
approved these changes
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
OMR::CodeGeneratorclass definesfunctionsgetSupportsBigDecimalLongLookasideVersioningandsetSupportsBigDecimalLongLookasideVersioningthat are not used in OMR.They only have relevance in OpenJ9 and should be relocated to the
J9::CodeGenerator class there.
Issue: eclipse-omr/omr#1882
Signed-off-by: Bohao(Aaron) Wang [email protected]