Add a VMLangAccess method to create threads #5778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a package access method java.lang.Thread:Thread(Runnable runnable, String threadName, boolean isSystemThreadGroup, boolean inheritThreadLocals, boolean isDaemon, ClassLoader contextClassLoader) which allows callers outside of java.lang package to create threads with such options via VMLangAccess interface. Specifically this supports java.io.ClassCache to create a thread that belongs to the system thread group, and not inherit ThreadLocals. Signed-off-by: Jason Feng <[email protected]>
|
jenkins test sanity plinux jdk11 depends ibmruntimes/openj9-openjdk-jdk11#170 |
pshipton
approved these changes
May 16, 2019
|
Please create a PR against the v0.14.2-release branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
VMLangAccessmethod to create threadsAdded a package access method
java.lang.Thread:Thread(Runnable runnable, String threadName, boolean isSystemThreadGroup, boolean inheritThreadLocals, boolean isDaemon, ClassLoader contextClassLoader)which allows callers outside ofjava.langpackage to create threads with such options viaVMLangAccessinterface.Specifically this supports
java.io.ClassCacheto create a thread that belongs to the system thread group, and not inheritThreadLocals.Related to ibmruntimes/openj9-openjdk-jdk11#170
Reviewer: @pshipton
FYI: @DanHeidinga
Signed-off-by: Jason Feng [email protected]