Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added DDRtest #5137

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Added DDRtest #5137

merged 1 commit into from
Apr 5, 2019

Conversation

Yuehan-Lin
Copy link
Contributor

[ci skip]
Signed-off-by: Yuehan-Lin [email protected]

@Yuehan-Lin Yuehan-Lin force-pushed the ddr branch 2 times, most recently from 8b353c2 to 3d8aa3d Compare March 18, 2019 16:29
@llxia
Copy link
Contributor

llxia commented Mar 18, 2019

jenkins test sanity win jdk8, jdk11

@llxia
Copy link
Contributor

llxia commented Mar 18, 2019

jenkins test sanity win jdk8

@llxia
Copy link
Contributor

llxia commented Mar 18, 2019

jenkins test sanity win jdk11

@llxia
Copy link
Contributor

llxia commented Mar 18, 2019

jenkins test extended xlinux,plinux,aix,zlinux,xlinuxlargeheap jdk11

@llxia
Copy link
Contributor

llxia commented Mar 19, 2019

jenkins test sanity win jdk11

@llxia
Copy link
Contributor

llxia commented Mar 19, 2019

jenkins test extended xlinux,plinux,aix,zlinux,xlinuxlargeheap jdk11

@llxia llxia mentioned this pull request Mar 19, 2019
Closed
keithc-ca
keithc-ca requested changes Mar 19, 2019
View reviewed changes
test/functional/DDR_Test/ddrSettings.mk Outdated Show resolved Hide resolved
test/functional/DDR_Test/playlist.xml Outdated Show resolved Hide resolved
test/functional/DDR_Test/playlist.xml Outdated Show resolved Hide resolved
test/functional/DDR_Test/src/j9vm/test/ddrext/Constants.java Outdated Show resolved Hide resolved
test/functional/DDR_Test/src/j9vm/test/ddrext/DDRExtTesterBase.java Outdated Show resolved Hide resolved
test/functional/DDR_Test/src/j9vm/test/ddrext/Constants.java Outdated Show resolved Hide resolved
test/functional/DDR_Test/src/j9vm/test/ddrext/junit/TestSharedClassesExt.java Outdated Show resolved Hide resolved
@Yuehan-Lin Yuehan-Lin force-pushed the ddr branch 3 times, most recently from 41613cd to 059ab14 Compare March 21, 2019 15:22
@Yuehan-Lin
Copy link
Contributor Author

@keithc-ca please review, thank you!

keithc-ca
keithc-ca requested changes Mar 21, 2019
View reviewed changes
test/functional/DDR_Test/ddrSettings.mk Outdated Show resolved Hide resolved
test/functional/DDR_Test/playlist.xml Outdated Show resolved Hide resolved
test/functional/DDR_Test/playlist.xml Outdated Show resolved Hide resolved
test/functional/DDR_Test/playlist.xml Outdated Show resolved Hide resolved
test/functional/DDR_Test/playlist.xml Outdated Show resolved Hide resolved
test/functional/DDR_Test/src/j9vm/test/ddrext/Constants.java Outdated Show resolved Hide resolved
test/functional/DDR_Test/src/j9vm/test/ddrext/junit/TestSharedClassesExt.java Outdated Show resolved Hide resolved
test/functional/DDR_Test/src/j9vm/test/ddrext/junit/TestSharedClassesExt.java Outdated Show resolved Hide resolved
test/functional/DDR_Test/tck_ddrext.xml Outdated Show resolved Hide resolved
test/functional/DDR_Test/tck_ddrext.xml Outdated Show resolved Hide resolved
@llxia
Copy link
Contributor

llxia commented Mar 25, 2019

DDR is supported on osx (PR #5127), please enable DDR tests on osx.

@Yuehan-Lin Yuehan-Lin force-pushed the ddr branch 3 times, most recently from 2a35841 to 8228e0a Compare March 25, 2019 15:33
@Yuehan-Lin
Copy link
Contributor Author

@keithc-ca ready for review

keithc-ca
keithc-ca requested changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@keithc-ca keithc-ca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also address earlier feedback.

test/functional/DDR_Test/playlist.xml Outdated Show resolved Hide resolved
test/functional/DDR_Test/src/j9vm/test/corehelper/CoreGen.java Outdated Show resolved Hide resolved
test/functional/DDR_Test/src/j9vm/test/ddrext/Constants.java Outdated Show resolved Hide resolved
test/functional/DDR_Test/src/j9vm/test/ddrext/junit/TestSharedClassesExt.java Outdated Show resolved Hide resolved
test/functional/DDR_Test/tck_ddrext.xml Outdated Show resolved Hide resolved
@Yuehan-Lin Yuehan-Lin force-pushed the ddr branch 4 times, most recently from b18983a to beee5b9 Compare March 26, 2019 16:07
keithc-ca
keithc-ca reviewed Mar 28, 2019
View reviewed changes
test/functional/DDR_Test/playlist.xml Outdated Show resolved Hide resolved
test/functional/DDR_Test/src/j9vm/test/ddrext/Constants.java Outdated Show resolved Hide resolved
test/functional/DDR_Test/tck_ddrext.xml Outdated Show resolved Hide resolved
keithc-ca
keithc-ca requested changes Apr 1, 2019
View reviewed changes
test/functional/DDR_Test/tck_ddrext.xml Outdated Show resolved Hide resolved
@Yuehan-Lin Yuehan-Lin force-pushed the ddr branch 3 times, most recently from aa8a8e5 to 9893a94 Compare April 3, 2019 15:18
@keithc-ca
Copy link
Contributor

Jenkins test extended aix,osx,plinux,xlinux,zlinux,win jdk8,jdk11

keithc-ca
keithc-ca requested changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@keithc-ca keithc-ca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the test needs some changes. It must load some extra classes not already in the shared class cache else this is to be expected:

     [java] [DDRExtTesterBase] [ERROR] '!walkinterntable  4' output does not contain success key : WALKING LOCAL INTERN HASHTABLE
     [java] [DDRExtTesterBase] [ERROR] '!walkinterntable  4' output :HeadNode is null

@Yuehan-Lin Yuehan-Lin force-pushed the ddr branch 3 times, most recently from 6e8acf6 to fccbf74 Compare April 4, 2019 20:29
@Yuehan-Lin
Added DDRtest
e64e421 
Fixed:eclipse-openj9#5095
[ci skip]
Signed-off-by: Yuehan-Lin <[email protected]>
@Yuehan-Lin
Copy link
Contributor Author

Last pr test failure is fixed, please review and test @keithc-ca

@keithc-ca
Copy link
Contributor

Jenkins test extended plinux jdk8,jdk11

@keithc-ca
Copy link
Contributor

Jenkins test extended aix,osx,xlinux,zlinux,win jdk8,jdk11

@keithc-ca
Copy link
Contributor

The AIX failure seems unrelated to this and more likely related to #3081.

@keithc-ca keithc-ca merged commit 42712f7 into eclipse-openj9:master Apr 5, 2019
@llxia
Copy link
Contributor

llxia commented Apr 5, 2019

@Yuehan-Lin Since runtimes/backlog/issues/124 is fixed, please re-enable zos in a separate PR.

@pshipton pshipton mentioned this pull request Apr 8, 2019
Closed
@theresa-m theresa-m mentioned this pull request Apr 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llxia llxia llxia left review comments

@smlambert smlambert smlambert left review comments

@keithc-ca keithc-ca keithc-ca approved these changes

Assignees
No one assigned
Labels
comp:test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yuehan-Lin @llxia @keithc-ca @smlambert