Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standardized branch range queries on Power #4959

Merged
merged 1 commit into from
Mar 6, 2019

Conversation

0xdaryl
Copy link
Contributor

@0xdaryl 0xdaryl commented Mar 4, 2019

  • Use the standard CodeGenerator query directCallRequiresTrampolines to
    determine the need for trampolines for direct calls and helpers.

  • Use platform-specific CPU queries to test call or branch instruction ranges
    when a CodeGenerator object is not available.

  • Remove forward and backward branch range macros

Signed-off-by: Daryl Maier [email protected]

* Use the standard CodeGenerator query `directCallRequiresTrampolines` to
determine the need for trampolines for direct calls and helpers.

* Use platform-specific CPU queries to test call or branch instruction ranges
when a CodeGenerator object is not available.

* Remove forward and backward branch range macros

Signed-off-by: Daryl Maier <[email protected]>
@0xdaryl
Copy link
Contributor Author

0xdaryl commented Mar 4, 2019

Jenkins test sanity plinux,aix jdk11

@0xdaryl
Copy link
Contributor Author

0xdaryl commented Mar 4, 2019

@gita-omr @ymanton , I'd appreciate a review and merge from at least one of you please.

Copy link
Member

@ymanton ymanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gita-omr gita-omr requested a review from ymanton March 5, 2019 15:59
@gita-omr
Copy link
Contributor

gita-omr commented Mar 5, 2019

I will take a look this afternoon.

@gita-omr
Copy link
Contributor

gita-omr commented Mar 5, 2019

Jenkins test extended plinux,aix jdk11

@gita-omr gita-omr self-requested a review March 5, 2019 16:30
@gita-omr
Copy link
Contributor

gita-omr commented Mar 5, 2019

Jenkins test extended plinux jdk11

@0xdaryl
Copy link
Contributor Author

0xdaryl commented Mar 5, 2019

Jenkins test extended aix jdk11

Previous build failed early for infrastructural reasons. One more try...

@0xdaryl
Copy link
Contributor Author

0xdaryl commented Mar 6, 2019

AIX extended test failures are #3081, which is not due to this PR. This PR can be merged (please).

@gita-omr gita-omr merged commit 37feb7b into eclipse-openj9:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants