Add support for generating SVM relocations on Power #4777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gita-omr @IBMJimmyk could you guys please review? |
gita-omr
reviewed
Feb 20, 2019
gita-omr
reviewed
Feb 20, 2019
Previously, it was generally assumed that any method calls generated under AOT would be unresolved calls. While this was historically true, it is no longer true when the Symbol Validation Manager is enabled. The Power codegen will now no longer force unresolved dispatch in these cases, instead using the new functionality to allow resolved dispatch. Signed-off-by: Ben Thomas <[email protected]>
Inlining of instanceof and checkcast tests in the Power codegen when running with the Symbol Validation Manager enabled has now been fixed to work correctly. This includes adding the correct validation records for profiled classes and single-implementer classes. Signed-off-by: Ben Thomas <[email protected]>
When evaluating an ArrayStoreCHK node, we add a test to see if the array being stored into is an Object[]. When storing to an Object[], there's no need to check the element's class, as all objects can be stored in an Object[]. However, the address for the Object class was being loaded without adding any relocations under AOT, which could cause incorrect behaviour. This has been fixed under SVM AOT, while the fast path is no longer generated under old AOT. Signed-off-by: Ben Thomas <[email protected]>
Object allocation inlining in the Power codegen now works correctly when the Symbol Validation Manager is enabled. The previous code was making a number of incorrect assumptions about what would happen under AOT, which have now been corrected. Specifically, when allocating an array, the old AOT infrastructure would put the address of the component class in classReg and the array class would be retrieved from that at runtime. Under SVM AOT, it is now possible to directly load the address of the array class, so classReg will now contain the address of the array class and the runtime retrieval of the array class from the component class is no longer necessary. Signed-off-by: Ben Thomas <[email protected]>
aviansie-ben
force-pushed
the
power-aot-svm-support
branch
from
44b4147 to
715b9d3
Compare
|
I've clarified a bit about the object allocation inlining changes in the description of the relevant commit. All other issues brought up have also been resolved. |
gita-omr
approved these changes
Feb 21, 2019
|
Jenkins test sanity,extended aix,plinux jdk8,jdk11 |
|
Jenkins may not be available until sometime tomorrow afternoon (CET) because of maintenance. |
|
can't do both sanity and extended in one go |
|
Jenkins test sanity aix,plinux jdk8,jdk11 |
|
Jenkins test extended aix,plinux jdk8,jdk11 |
|
extended jdk11 inux_ppc-64_cmprssptrs_le build failed with |
|
Jenkins test extended plinux jdk11 |
|
Looks like Jenkins is still not working? |
|
Jenkins test sanity,extended aix,plinux jdk8,jdk11 |
|
Jenkins test sanity plinux jdk8,jdk11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a number of problematic sections of the Power codegen that did not properly handle being run under AOT. While these sections were previously not run under AOT due to the limitations of AOT in general, they can run when SVM AOT is being used. These sections have been fixed up to properly handle adding AOT relocations when run under SVM AOT.