Add a new target to generate jvmti.h when build with linter in travis #4605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new target is necessary because it generates jvmti header files. Since we need to generate different jvmti header files for different JDKs and building with linter doesn't depend on extension repository, we have to modify makefiles so that it generates jvmti header files when build with linter. PRs should be commited in such order: * jvmti.h.m4 which generates jvmti header files(eclipse-openj9#4409) * changes in extension repositories(JDK8, JDK11, JDK12) * changes in JDK11(eclipse-openj9#116) in its specific extension repository * changes in how openj9 are build with linter(eclipse-openj9#4605) There are some changes: * A new target(java_spec_headers) is added * A new recipe of target java_spec_headers is added: it gets java_spec_version from j9cfg.h then uses it as a variable Signed-off-by: MarkQingGuo <[email protected]>
MarkQingGuo
force-pushed
the
buildchange
branch
from
4cecfa1 to
d2087b2
Compare
|
@keithc-ca here maybe other changes we need, if we want to build on travis. |
|
I am hoping that #4409 will be updated to handle cmake builds so that this is unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new target(java_spec_headers) is added in build-on-travis.mk
A new target is necessary because it generates jvmti header files. Since we need to generate different jvmti header files for different JDKs and building with linter doesn't depend on extension repository, we have to modify makefiles so that it generates jvmti header files when build with linter.
PRs should be commited in such order:
There are some changes:
Signed-off-by: MarkQingGuo [email protected]