Set domainCombiner from closest frame in result AccessControlContext #3051
Conversation
jcl/src/java.base/share/classes/java/security/AccessController.java
Outdated
Show resolved
Hide resolved
For JEP140 Format result of getAccSnapshot, returning AccessControlContext.domainCombiner is set to a non-null DomainCombiner of an AccessControlContext object from the closest frame objects or null. Signed-off-by: Jason Feng <[email protected]>
|
jenkins test all zlinux jdk8 |
|
jenkins test sanity plinux jdk11 |
|
@JasonFengJ9 this PR closed #2990, but @llxia tells me the test for #2990 is still failing. Also it doesn't look like the correct Issue to have closed, was there a typo? |
|
@pshipton it has been a while (more than two years ago). From the comments within #2990, this appears related, I think it wasn't a typo. @LongyuZhang is narrowing down if this is a regression. |
|
@JasonFengJ9 Tested with old sdk 20181206 from vmfarm, for jdk_security4 (Internal_grinder 12217), it failed 126 out of 135 tests, for this specific HttpNegotiateServer test, it failed at compilation, same as the original issue (#2990 (comment)). In addition, I found jdk_security4 test was enabled only since Nov.13, 2018 (adoptium/aqa-tests#681), after this issue has already been closed (Sep.27, 2018). I will open another issue to add more details. Thanks. |
Set
domainCombinerfrom closest frame in resultAccessControlContextofj.s.AccessController.getContextHelper()For
JEP140Format result ofj.s.AccessController.getAccSnapshot(), returningAccessControlContext.domainCombineris set to anon-null DomainCombinerof anAccessControlContextobject from the closest frame objects ornull.Verified that the failed testcase passes and
pConfigstill compiles.close: #2990
Reviewer: @pshipton
FYI: @DanHeidinga
Signed-off-by: Jason Feng [email protected]