Fix for missing NULLCHK in Unsafe atomics #3036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NULLCHK on receiver is missing when transforming Unsafe.getAndAdd/Set. Fixing it. Signed-off-by: Victor Ding <[email protected]>
|
Jenkins test sanity xlinux,win jdk8,jdk11 |
andrewcraik
reviewed
Sep 27, 2018
| if (treetop->getNode()->getOpCodeValue() == TR::NULLCHK) | ||
| { | ||
| auto nullchk = comp()->getSymRefTab()->findOrCreateNullCheckSymbolRef(comp()->getMethodSymbol()); | ||
| treetop->insertBefore(TR::TreeTop::create(comp(), TR::Node::createWithSymRef(TR::NULLCHK, 1, 1, TR::Node::create(node, TR::PassThrough, 1, node->getChild(0)), nullchk))); |
There was a problem hiding this comment.
Does this need bc info?
There was a problem hiding this comment.
Not in this case. TR::Node::createWithSymRef copies bc info from its child.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NULLCHK on receiver is missing when transforming Unsafe.getAndAdd/Set.
Fixing it.
Signed-off-by: Victor Ding [email protected]