Remove Java_com_ibm_jit_crypto_* from jithelpers uma object #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshipton
reviewed
Oct 5, 2017
| @@ -64,7 +64,12 @@ public void addArtifact(Artifact artifact) throws UMAException { | |||
| } | |||
|
|
|||
| public void addExports(String group, Exports exps) { | |||
| exports.put(group, exps); | |||
| if ( exports.keySet().contains(group) ) { | |||
pshipton
reviewed
Oct 5, 2017
| @@ -64,7 +64,12 @@ public void addArtifact(Artifact artifact) throws UMAException { | |||
| } | |||
|
|
|||
| public void addExports(String group, Exports exps) { | |||
| exports.put(group, exps); | |||
| if ( exports.keySet().contains(group) ) { | |||
| exps.addExports(exports.get(group)); | |||
There was a problem hiding this comment.
To avoid unexpected problems, and just as good practice, please create a new Exports rather than modifying the parameter.
There was a problem hiding this comment.
@pshipton Fixed as suggested, thx!
pshipton
reviewed
Oct 5, 2017
| if ( exports.containsKey(group) ) { | ||
| Exports allGroupExports = exports.get(group); | ||
| allGroupExports.addExports(exps); | ||
| exports.replace(group, allGroupExports); |
There was a problem hiding this comment.
This shouldn't be needed, since the Exports in the Map was already modified on the previous line.
There was a problem hiding this comment.
Right, corrected, thx!
Move crypto exports to vendors jcl exports files Update module.xml to include the export file when available Fixed uma exports parser Signed-off-by: Violeta Sebe <[email protected]>
|
jenkins test sanity plinux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move crypto exports to vendors jcl exports files.
Update module.xml to include the export file when available.
Fixed uma exports parser.
This fix is related to issue: #55.
Signed-off-by: Violeta Sebe [email protected]