Fix Runtime Instrumentation Control Block Mapping #2497
Conversation
Remove mapping to suspension control at word 6 byte 3 bit 4 which should be reserved and add mappings for suppression control and guarded storage. Signed-off-by: Daniel Hong <[email protected]>
runtime/port/common/j9ri.h
Outdated
| uint32_t pad3:2; | ||
|
|
||
| uint32_t guardedStorage:1; | ||
| uint32_t pad3:1; |
There was a problem hiding this comment.
Could we use a better name for the paddings? It would be much easier to make sure the offsets are correct if for example pad3 was renamed to be something like padAtBit15. Similarly elsewhere.
There was a problem hiding this comment.
Sure, with the first padding, pad29, is that name clear since it is a 29 bit padding at the start of word 6 or should we think of something more descriptive?
There was a problem hiding this comment.
Let's make the naming consistent. I'm not picky about what it should be. It shouldn't matter whether the pad is at the start on in the middle. The name should be descriptive enough to tell you where the padding is. The bit field will always tell how big the padding is.
Change padding names inj9ri.h to indicate the start of padding with both the word and bit number. Signed-off-by: Daniel Hong <[email protected]>
|
Jenkins test sanity depends eclipse/omr#master |
|
Looks like failures are due to #2129 |
|
Travis builds will fail until we have an OMR promotion. We should be good here. |
Remove mapping to suspension control at word 6 byte 3 bit 4
which should be reserved and add mappings for suppression
control and guarded storage.
Signed-off-by: Daniel Hong [email protected]