Optimized prolog/epilog for private linkage on X86 #2460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the prolog/epilog generated by private linkage only allocates/deallocates stack once. Signed-off-by: Victor Ding <[email protected]>
|
The new code combines padding size with frame size so that only one sub/add instead of 2 is needed in both prolog/epilog. LGTM. |
fjeremic
approved these changes
Jul 26, 2018
|
Approved based on @cathyzhyi's review. Jenkins test sanity |
|
Windows failures due to #2129 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the prolog/epilog generated by private linkage only allocates/deallocates stack once.
Signed-off-by: Victor Ding [email protected]