Ensure JAVA_SPEC_VERSION is defined for OMR compilation #2374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: eclipse-openj9#2373 Signed-off-by: Keith W. Campbell <[email protected]>
|
jenkins test sanity plinux,win jdk8,jdk10 |
|
The travis ci build hasn't started yet. This change is to fix Java 11 and won't affect cmake, which builds Java 9 atm. There may be an equivalent change required to support cmake, but if so it doesn't need to block merging this. |
|
I spoke with @dnakamura. He tells me that OMR is just treated as a subproject of OpenJ9 and should inherit all the macro definitions that belong on the command line: if Java 11 were supported with cmake, it would work without this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an interim solution to #2373.