Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process zip files up to 4 GB #2245

Merged
merged 4 commits into from
Jun 28, 2018
Merged

Process zip files up to 4 GB #2245

merged 4 commits into from
Jun 28, 2018

Conversation

pdbain-ibm
Copy link
Contributor

Change 32-bit signed variables to unsigned variables to allow zip/jar files up
to 4 GB. Use a common function to check if results are in the correct range.

Signed-off-by: Peter Bain [email protected]

Change 32-bit signed variables to unsigned variables to allow zip/jar files up
to 4 GB. Use a common function to check if results are in the correct range.

Signed-off-by: Peter Bain <[email protected]>
@pdbain-ibm
Copy link
Contributor Author

@gacholio would you kindly review? Thank you

@pdbain-ibm pdbain-ibm changed the title WIP Process zip files up to 4 GB Process zip files up to 4 GB Jun 21, 2018
@pdbain-ibm
Copy link
Contributor Author

@DanHeidinga or @gacholio would you kindly run pull request builds.
Thank you

@gacholio gacholio self-requested a review June 22, 2018 19:12
Signed-off-by: Graham Chapman <[email protected]>
@gacholio
Copy link
Contributor

jenkins test sanity xlinux jdk8

@gacholio
Copy link
Contributor

IP validation and signed off checks fail due to the merge commit from git. copyright failure is some other foolishness unrelated to this PR.

@gacholio gacholio merged commit 49d6e21 into eclipse-openj9:master Jun 28, 2018
AdamBrousseau added a commit to AdamBrousseau/openj9 that referenced this pull request Jul 5, 2018
This reverts commit 49d6e21, reversing
changes made to a934baf.
@pdbain-ibm pdbain-ibm deleted the jar branch August 23, 2019 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants