Link to C++ library statically on some platforms #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mstoodle This is the best way I can think of to statically link to libstdc++. It can be further cleaned up if we decide to drop support for GCC below version 4.5. |
|
@mgaudet @charliegracie FYI for CMake support. |
0dvictor
force-pushed
the
StaticLink
branch
2 times, most recently
from
4f28c3f to
a5c1d2f
Compare
0dvictor
force-pushed
the
StaticLink
branch
2 times, most recently
from
48bc2d6 to
5bf86d3
Compare
0dvictor
changed the title
|
jenkins test sanity |
JIT on a platform that use GNU toolchain now link to libstdc++ statically. Signed-off-by: Victor Ding <[email protected]>
|
jenkins test sanity |
|
Given the simplicity of this change, I'm going to merge it to avoid the libstdc++ dependency from the JIT, and because I believe this is consistent with what OpenJDK does. It does imply that the build environment should be as similar as possible to the runtime environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIT on a platform that use GNU toolchain now link to libstdc++ statically.
Signed-off-by: Victor Ding [email protected]