-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SVM AOT support for resolved invokeHandle/invokeDynamic dispatch #20373
base: master
Are you sure you want to change the base?
Conversation
Add new TR_RelocationErrorCode kinds to indicate validation failures for TR_ValidateDynamicMethodFromCallsiteIndex and TR_ValidateHandleMethodFromCPIndex. Signed-off-by: Irwin D'Souza <[email protected]>
Signed-off-by: Irwin D'Souza <[email protected]>
Signed-off-by: Irwin D'Souza <[email protected]>
Signed-off-by: Irwin D'Souza <[email protected]>
@hangshao0 does f9c7eba look like the proper way to conditionally support storing LambdaForms into the SCC? I wanted something like this so that we can add AOT MH tests without having to enable by default both LambdaForms in the SCC & Resolved |
Looks mostly fine. But you may want to set |
Signed-off-by: Irwin D'Souza <[email protected]>
1e73b80
to
2e06461
Compare
@jdmpapin could you please review? @hangshao0 could you please review the VM changes? |
For now, is the new option I remember the reason of not storing lambdaForms class is that it has a performance issue. Storing lambdaForms requires the VM to do extra class comparisons before we can return the correct lamdaForm class. There is a PR #19763 that could address the performance issue. But it is not merged so the performance issue is still there. |
I'm treating this as an internal option for devs/testing. It can be deleted in the future when LambdaForms are stored into the SCC. Is there a better way to create/use an option for dev/testing purposes? |
The reason I was asking is because public option needs to be documented in the user guide, but since it it private option, we don't need documentation change. The way you are doing it here is fine. |
Signed-off-by: Irwin D'Souza <[email protected]>
Signed-off-by: Irwin D'Souza <[email protected]>
2e06461
to
512fe57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
-Xshareclasses:shareLambdaForm
is enabled.Depends on eclipse/omr#7494