Throw NoClassDefFoundError: MH.resolveInvokeDynamic(...) #20

babsingh · 2017-09-14T19:49:19Z

If ConstantPool.getClassAt(...) returns null while resolving bootstrap
method handles, then we should throw NoClassDefFoundError, and the
cause of NoClassDefFoundError should be ClassNotFoundException. The
message of NoClassDefFoundError and ClassNotFoundException should
contain the name of the class, which wasn't found.

Signed-off-by: Babneet Singh [email protected]

genie-openj9 · 2017-09-19T01:23:27Z

Can one of the admins verify this patch?

genie-openj9 · 2017-09-19T01:27:28Z

Can one of the admins verify this patch?

genie-openj9 · 2017-09-19T01:32:22Z

Can one of the admins verify this patch?

babsingh · 2017-09-21T15:58:34Z

@AdamBrousseau the builds are failing without any errors. same issue noticed for #19.

DanHeidinga · 2017-09-21T16:09:17Z

@babsingh Did you force push at some point? The builds get confused when the sha they expect isn't in the repo anymore

babsingh · 2017-09-21T17:14:19Z

@DanHeidinga yes. how to fix this issue?

DanHeidinga · 2017-09-21T17:16:39Z

I've restarted the build on travis. Let's see if it passes now

babsingh · 2017-09-22T15:06:02Z

@DanHeidinga the build still failed.

DanHeidinga

Some doc updates required, otherwise looks good

DanHeidinga · 2017-09-22T16:08:05Z

jcl/src/java.base/share/classes/java/lang/invoke/MethodHandle.java

+	 * Retrieve the class name of the constant pool class element located at the specified
+	 * index in clazz's constant pool. Then, throw a NoClassDefFoundError with the cause
+	 * set as ClassNotFoundException. The message of NoClassDefFoundError and 
+	 * ClassNotFoundException contains the name of the class, which couldn't be found.


Can you add javadoc style comment for the arguments / return types?

DanHeidinga · 2017-09-22T16:13:57Z

runtime/jcl/common/sun_reflect_ConstantPool.c

@@ -459,6 +459,41 @@ Java_sun_reflect_ConstantPool_getFieldAtIfLoaded0(JNIEnv *env, jobject unusedObj
 }

 jobject JNICALL
+Java_java_lang_invoke_MethodHandle_getClassNameAt(JNIEnv *env, jobject unusedObject, jobject constantPoolOop, jint cpIndex)


Please a function comment that describes the arguments, the return types and any invariants.

DanHeidinga · 2017-09-22T16:15:47Z

jcl/src/java.base/share/classes/java/lang/invoke/MethodHandle.java

+	 * set as ClassNotFoundException. The message of NoClassDefFoundError and 
+	 * ClassNotFoundException contains the name of the class, which couldn't be found.
+	 */
+	private static Throwable noClassDefFoundError(Class<?> clazz, int index) {


Its totally a nitpick, but can you call this throwNoClassDefFoundError(...)? so it will match the naming convention in the j.l.i. package for these kinds of methods

DanHeidinga · 2017-09-25T17:44:32Z

jcl/src/java.base/share/classes/java/lang/invoke/MethodHandle.java

+	 * Get the class name from a constant pool class element, which is located at the
+	 * specified index in clazz's constant pool.
+	 */
+	private static final native String getClassNameAt(Class<?> clazz, int index);


My apologies - I missed a naming convention issue. All the other MH-constantPool related methods have a CP prefix - i.e.: getCPClassNameAt

see:

Java_java_lang_invoke_MethodHandle_getCPTypeAt Java_java_lang_invoke_MethodHandle_getCPMethodTypeAt Java_java_lang_invoke_MethodHandle_getCPMethodHandleAt

And Javadoc the method as well please.

changed name to getCPClassNameAt, added Java doc for getCPClassNameAt, and resolved merge conflicts that arose from merging #19

If ConstantPool.getClassAt(...) returns null while resolving bootstrap method handles, then we should throw NoClassDefFoundError, and the cause of NoClassDefFoundError should be ClassNotFoundException. The message of NoClassDefFoundError and ClassNotFoundException should contain the name of the class, which wasn't found. Signed-off-by: Babneet Singh <[email protected]>

DanHeidinga · 2017-09-27T19:36:10Z

Jenkins test sanity

DanHeidinga · 2017-09-27T19:36:21Z

This is ready to merge once the sanity builds pass.

babsingh · 2017-09-27T20:38:58Z

@DanHeidinga Sanity Tests have failed due to the following error:
tr.source/trj9/optimizer/J9Optimizer.cpp:85:45: error: ‘IfVoluntaryOSR’ is not a member of ‘OMR’
Should I rebase to fix this issue?

pshipton · 2017-09-28T00:44:59Z

jenkins test sanity

pshipton · 2017-09-28T00:46:00Z

tr.source/trj9/optimizer/J9Optimizer.cpp:85:45: error: ‘IfVoluntaryOSR’ is not a member of ‘OMR’

this was a temporarily problem as a PR was merged before the required OMR content had promoted.

Disable Windows OpenJ9 Java 8 builds temporarily

* Updated JVMImageHeader and fixed reading from file * Formatting fixup * Moved the header's buffer to the stack Signed-off-by: Brady Jessup <[email protected]>

…e-queries Move value type query methods to ClassEnv

babsingh force-pushed the jcl_npe_to_ncdfe branch from f99a4a5 to 0ce9d83 Compare September 14, 2017 19:52

babsingh changed the title ~~Throw NoClassDefFoundError: MH.resolveInvokeDynamic(...)~~ WIP: Throw NoClassDefFoundError: MH.resolveInvokeDynamic(...) Sep 14, 2017

babsingh force-pushed the jcl_npe_to_ncdfe branch from 0ce9d83 to 76de5dc Compare September 19, 2017 22:09

babsingh changed the title ~~WIP: Throw NoClassDefFoundError: MH.resolveInvokeDynamic(...)~~ Throw NoClassDefFoundError: MH.resolveInvokeDynamic(...) Sep 19, 2017

babsingh force-pushed the jcl_npe_to_ncdfe branch 4 times, most recently from a724832 to 5961bb5 Compare September 19, 2017 22:19

pshipton added the comp:vm label Sep 20, 2017

babsingh force-pushed the jcl_npe_to_ncdfe branch from 5961bb5 to 479e552 Compare September 20, 2017 19:57

babsingh changed the title ~~Throw NoClassDefFoundError: MH.resolveInvokeDynamic(...)~~ WIP: Throw NoClassDefFoundError: MH.resolveInvokeDynamic(...) Sep 20, 2017

DanHeidinga requested changes Sep 22, 2017

View reviewed changes

tajila mentioned this pull request Sep 22, 2017

Crash running gradle reported on StackOverflow #110

Closed

babsingh force-pushed the jcl_npe_to_ncdfe branch 2 times, most recently from a51643d to 121b44d Compare September 25, 2017 17:28

babsingh changed the title ~~WIP: Throw NoClassDefFoundError: MH.resolveInvokeDynamic(...)~~ Throw NoClassDefFoundError: MH.resolveInvokeDynamic(...) Sep 25, 2017

DanHeidinga reviewed Sep 25, 2017

View reviewed changes

babsingh force-pushed the jcl_npe_to_ncdfe branch from 121b44d to ee14d38 Compare September 25, 2017 18:56

babsingh force-pushed the jcl_npe_to_ncdfe branch from ee14d38 to a45bf26 Compare September 25, 2017 19:02

DanHeidinga approved these changes Sep 27, 2017

View reviewed changes

pshipton merged commit b5f3cc5 into eclipse-openj9:master Sep 28, 2017

babsingh deleted the jcl_npe_to_ncdfe branch September 28, 2017 03:43

babsingh mentioned this pull request Nov 16, 2017

Throw NoClassDefFoundError instead of TypeNotPresentException #610

Merged

amicic pushed a commit to amicic/openj9 that referenced this pull request Jan 16, 2018

Merge pull request eclipse-openj9#20 from Peter-Shipton/disablewinj8

0f7929a

Disable Windows OpenJ9 Java 8 builds temporarily

myspringchen mentioned this pull request Mar 9, 2018

Should OpenJ9 throw a verifyerror for my test class? #1404

Closed

urisimchoni mentioned this pull request Apr 2, 2018

JIT failure when JVMTI field watches are added #1572

Closed

ChengJin01 mentioned this pull request Aug 30, 2018

Reject illegal entries in the bootstrap argument array #2700

Merged

DanHeidinga mentioned this pull request Jun 3, 2019

jdk11: jtreg java/util/concurrent/ArrayBlockingQueue/WhiteBox.java crashes on MacOS #5988

Closed

tajila pushed a commit to tajila/openj9 that referenced this pull request Jul 11, 2019

JVM Image Fixes (eclipse-openj9#20)

3ae4fdf

* Updated JVMImageHeader and fixed reading from file * Formatting fixup * Moved the header's buffer to the stack Signed-off-by: Brady Jessup <[email protected]>

kusumachalasani mentioned this pull request Oct 14, 2019

Dacapo sub-benchmark "eclipse" crashes when run with large load #7452

Open

hzongaro pushed a commit to hzongaro/openj9 that referenced this pull request Mar 31, 2020

Merge pull request eclipse-openj9#20 from hzongaro/drop-j9vm-valuetyp…

a010c1e

…e-queries Move value type query methods to ClassEnv

LongyuZhang mentioned this pull request Oct 23, 2020

testSCCMLTests1_openj9_1 failed with openjdk11 Aarch64 #10741

Open

mpirvu mentioned this pull request Apr 19, 2021

"Unknown bytecode to JIT 206" assert failure during testJITServer_1 #12468

Closed

manqingl mentioned this pull request Jun 16, 2021

Infinite loop leading to memory corruption and crash. #12979

Closed

a0304 mentioned this pull request Aug 3, 2021

OpenJ9 JVM crash when loading native library in Linux #13269

Open

urisimchoni mentioned this pull request Nov 23, 2021

Crash or OutOfMemoryError when using AsyncGetCallTrace() #13838

Closed

mkarrahcl mentioned this pull request Sep 26, 2023

"dump java core" is hanging process on RHEL 9.1/9.2 using Semeru OpenJDK 17 #18204

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Throw NoClassDefFoundError: MH.resolveInvokeDynamic(...) #20

Throw NoClassDefFoundError: MH.resolveInvokeDynamic(...) #20

babsingh commented Sep 14, 2017 •

edited

Loading

genie-openj9 commented Sep 19, 2017

genie-openj9 commented Sep 19, 2017

genie-openj9 commented Sep 19, 2017

babsingh commented Sep 21, 2017

DanHeidinga commented Sep 21, 2017

babsingh commented Sep 21, 2017

DanHeidinga commented Sep 21, 2017

babsingh commented Sep 22, 2017 •

edited

Loading

DanHeidinga left a comment

DanHeidinga Sep 22, 2017

babsingh Sep 25, 2017

DanHeidinga Sep 22, 2017

babsingh Sep 25, 2017

DanHeidinga Sep 22, 2017

babsingh Sep 25, 2017

DanHeidinga Sep 25, 2017

babsingh Sep 25, 2017

DanHeidinga commented Sep 27, 2017

DanHeidinga commented Sep 27, 2017

babsingh commented Sep 27, 2017

pshipton commented Sep 28, 2017

pshipton commented Sep 28, 2017

Throw NoClassDefFoundError: MH.resolveInvokeDynamic(...) #20

Throw NoClassDefFoundError: MH.resolveInvokeDynamic(...) #20

Conversation

babsingh commented Sep 14, 2017 • edited Loading

genie-openj9 commented Sep 19, 2017

genie-openj9 commented Sep 19, 2017

genie-openj9 commented Sep 19, 2017

babsingh commented Sep 21, 2017

DanHeidinga commented Sep 21, 2017

babsingh commented Sep 21, 2017

DanHeidinga commented Sep 21, 2017

babsingh commented Sep 22, 2017 • edited Loading

DanHeidinga left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DanHeidinga commented Sep 27, 2017

DanHeidinga commented Sep 27, 2017

babsingh commented Sep 27, 2017

pshipton commented Sep 28, 2017

pshipton commented Sep 28, 2017

babsingh commented Sep 14, 2017 •

edited

Loading

babsingh commented Sep 22, 2017 •

edited

Loading