Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find modules for MHProxies.asInterfaceInstance's hidden classes #18780

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

babsingh
Copy link
Contributor

In JDK22, MethodHandleProxies.asInterfaceInstance was reimplemented
using a more direct MethodHandle approach to improve performance.
This approach introduces hidden classes which have an interface for
its host class. A dynamic module is created for each such hidden
class. This PR correctly finds and sets java.lang.Class.module for
such hidden classes.

Fixes: #18718

@babsingh babsingh marked this pull request as ready for review January 19, 2024 21:11
@babsingh
Copy link
Contributor Author

@hangshao0 Can you please review this PR?

In JDK22, MethodHandleProxies.asInterfaceInstance was reimplemented
using a more direct MethodHandle approach to improve performance.
This approach introduces hidden classes which have an interface for
its host class. A dynamic module is created for each such hidden
class. This PR correctly finds and sets java.lang.Class.module for
such hidden classes.

Fixes: eclipse-openj9#18718

Signed-off-by: Babneet Singh <[email protected]>
@hangshao0
Copy link
Contributor

jenkins test sanity.functional,extended.functional alinux jdk22

@hangshao0
Copy link
Contributor

jenkins test sanity.openjdk,extended.openjdk alinux jdk22

@hangshao0
Copy link
Contributor

@babsingh Are you looking at the failures in the PR builds ?

@babsingh
Copy link
Contributor Author

Are you looking at the failures in the PR builds ?

Yes, I am opening new issues for those failures. They are unrelated. I will post a comment in this PR once I am done.

@babsingh
Copy link
Contributor Author

babsingh commented Jan 24, 2024

Known JDK22 failures:

New JDK22 failures (fyi @pshipton, @JasonFengJ9, @tajila for tracking purposes, in case these failures are seen while triaging builds):

@hangshao0 My changes are not responsible for the PR build failures. Some failures are known, and new issues have been opened for the failures, which are seen for the first time.

Copy link
Contributor

@hangshao0 hangshao0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hangshao0 hangshao0 merged commit de7807c into eclipse-openj9:master Jan 24, 2024
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JDK22 MHProxies.asInterfaceInstance: named module expected
2 participants