-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find modules for MHProxies.asInterfaceInstance's hidden classes #18780
Conversation
@hangshao0 Can you please review this PR? |
In JDK22, MethodHandleProxies.asInterfaceInstance was reimplemented using a more direct MethodHandle approach to improve performance. This approach introduces hidden classes which have an interface for its host class. A dynamic module is created for each such hidden class. This PR correctly finds and sets java.lang.Class.module for such hidden classes. Fixes: eclipse-openj9#18718 Signed-off-by: Babneet Singh <[email protected]>
jenkins test sanity.functional,extended.functional alinux jdk22 |
jenkins test sanity.openjdk,extended.openjdk alinux jdk22 |
@babsingh Are you looking at the failures in the PR builds ? |
Yes, I am opening new issues for those failures. They are unrelated. I will post a comment in this PR once I am done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
In JDK22,
MethodHandleProxies.asInterfaceInstance
was reimplementedusing a more direct
MethodHandle
approach to improve performance.This approach introduces hidden classes which have an interface for
its host class. A dynamic module is created for each such hidden
class. This PR correctly finds and sets
java.lang.Class.module
forsuch hidden classes.
Fixes: #18718