Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fake pull request #18579

Closed
wants to merge 1 commit into from
Closed

Conversation

hzongaro
Copy link
Member

@hzongaro hzongaro commented Dec 7, 2023

Need to try out a PR build with a branch that has no real changes. Not to be merged.

@hzongaro hzongaro self-assigned this Dec 7, 2023
@hzongaro
Copy link
Member Author

hzongaro commented Dec 7, 2023

Running standard testing with value types enabled:

Jenkins test sanity xlinuxvalst jdknext

@pshipton
Copy link
Member

pshipton commented Dec 7, 2023

You should be able to do this via https://openj9-jenkins.osuosl.org/job/Pipeline-Build-Test-Personal/
From looking at the PR build afaik you specify x86-64_linux_vt_standard as the platform and https://github.com/ibmruntimes/openj9-openjdk-jdk.valuetypes.git as the JDK_REPO.

@hangshao0
Copy link
Contributor

@JasonFengJ9 The Valhalla build failure here might be caused by Valhalla extension repo not updated with the latest Jdknext repo.

@JasonFengJ9
Copy link
Member

The Valhalla build failure here might be caused by Valhalla extension repo not updated with the latest Jdknext repo.

Current valhalla is at jdk-22+15 which is well behind OpenJDK head jdk-23+1.

This gap caused the merging conflicts for openj9-openjdk-jdk.valuetypes, preventing merging with recent OpenJDK updates, and causing this PR test failure.
Resolving the merging conflict and porting OpenJDK jdk-23+1 changes to valhalla extension repo requires large changes and seems risky.
Proposing Valhalla disables JDK22+ Jep454Tests temporarily until the Valhalla project is updated w/ a recent OpenJDK tag.

@hzongaro hzongaro closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants