-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Criu test failures for JITServer SSL Tests #18225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Would it be better to not remove the output that was previously |
@dsouzai Ideally I would think that either of the |
As long as the JVM being tested works in client mode, one of the two messages will be printed. |
1b14666
to
306b3b8
Compare
@dsouzai I have added extra conditions which should take care of both cases. |
jenkins test sanity.functional xlinux,plinux,zlinux jdk17 |
linux failures due to existing issues:
see #17844 (comment),
see #16945 |
Recently added CRIU tests are failing in some cases because of the
required
condition, which will never succeed if we don't have a vlog because of cases like when CRIU can't acquire the original thread IDs. In such cases the output with have something similar to:The tests conditions needs to be altered to adapt to this expected scenario and silently succeed in such cases.
Fixes: #18148
Fixes: #18140