Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JDK21] Add support for JVMTI PopFrame #17809

Merged
merged 1 commit into from
Jul 25, 2023
Merged

[JDK21] Add support for JVMTI PopFrame #17809

merged 1 commit into from
Jul 25, 2023

Commits on Jul 17, 2023

  1. [JDK21] Add support for JVMTI PopFrame 

    Previously, PopFrame returned JVMTI_ERROR_OPAQUE_FRAME for a virtual
thread.

In JDK21, PopFrame includes support for virtual threads as per the
JVMTI specification:
- Error if a virtual thread is not suspended and not the current
  thread.
- Error if a virtual thread is unomunted since it won't be able to
  pop the current frame.
- For a carrier thread with a virtual thread mounted, the details of
  the carrier thread are derived from targetThread->currentContinuation.

Related:
- eclipse-openj9#17715
- eclipse-openj9#17716

Also, there is no need to halt and resume a thread for inspection since
PopFrame expects the thread to be suspended as per the JVMTI spec. If a
thread is not suspended, it returns JVMTI_ERROR_THREAD_NOT_SUSPENDED.

Signed-off-by: Babneet Singh <[email protected]>
    @babsingh
    babsingh committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    b318f52 View commit details
    Browse the repository at this point in the history