Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document virtual thread issues in the 0.37 release notes #17179

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Document virtual thread issues in the 0.37 release notes #17179

merged 1 commit into from
Apr 14, 2023

Conversation

babsingh
Copy link
Contributor

@babsingh babsingh commented Apr 13, 2023 •
edited
Loading

@babsingh babsingh force-pushed the release_notes_37 branch 5 times, most recently from f72e53b to fcc8ac4 Compare April 13, 2023 15:49
@babsingh
Copy link
Contributor Author

@pshipton @fengxue-IS This PR is ready to be reviewed. Let me know if any other issue should be mentioned in the release notes.

@fengxue-IS
Copy link
Contributor

note lgtm

@pshipton pshipton requested a review from keithc-ca April 13, 2023 17:44
keithc-ca
keithc-ca requested changes Apr 13, 2023
View reviewed changes
doc/release-notes/0.37/0.37.md Outdated Show resolved Hide resolved
doc/release-notes/0.37/0.37.md Outdated Show resolved Hide resolved
doc/release-notes/0.37/0.37.md Outdated Show resolved Hide resolved
doc/release-notes/0.37/0.37.md Outdated Show resolved Hide resolved
@babsingh babsingh force-pushed the release_notes_37 branch 2 times, most recently from 2efae0c to 8e20369 Compare April 13, 2023 20:24
@babsingh
Copy link
Contributor Author

@mstoodle @keithc-ca I have addressed all the feedback. Please let me know if it was not correctly addressed.

@mstoodle
Copy link
Contributor

Thanks, @babsingh but I still see some phrases "due to underlying problems in OpenJDK" which has same flavour as my comment on OpenJ9. We know where the problem resides, but it doesn't matter to a user.

@babsingh
Copy link
Contributor Author

I still see some phrases "due to underlying problems in OpenJDK"

Fixed, I had missed it.

@pshipton
Copy link
Member

I don't think we need to include "Such an error might never be seen due to the very low failure rate." either.

@babsingh
Copy link
Contributor Author

I don't think we need to include "Such an error might never be seen due to the very low failure rate." either.

All instances have been removed.

@pshipton pshipton added this to the Java 19 0.37 milestone Apr 14, 2023
@keithc-ca keithc-ca merged commit e864677 into eclipse-openj9:master Apr 14, 2023
@pshipton pshipton mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshipton pshipton pshipton left review comments

@mstoodle mstoodle mstoodle left review comments

@keithc-ca keithc-ca keithc-ca approved these changes

Assignees
No one assigned
Labels
comp:doc
Projects
None yet
Milestone
Java 19 0.37
Development

Successfully merging this pull request may close these issues.
5 participants
@babsingh @fengxue-IS @mstoodle @pshipton @keithc-ca