Properly initalize superclass of IlGeneratorMethodDetails #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I take it you will eventually need it to do something other than default construct its parent? Because it should be doing that automatically anyway. |
|
Hmm. If that's true, I could withdraw this. I wasn't 100% sure that was the case, and was leaning towards Explicit > Implicit. I'm OK either way then |
|
I'm all for changing magic into prescription |
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Jenkins test sanity |
|
I prefer to make it explicit since this little corner of class hierarchy is not really straight-forward. |
mstoodle
requested changes
Oct 4, 2017
Currently we don't properly IlGeneratorMethodDetails, however that hasn't harmed us because it has no state. However, I'm trying to add a field to the OMR::IlGeneratorMethodDetails which will require it to be initalized, so this commit adds the required call to the parent constructor. Signed-off-by: Matthew Gaudet <[email protected]>
mgaudet
force-pushed
the
InitializeMethodDetails
branch
from
b6f344b to
e5da320
Compare
|
Rebased, corrected copyright. |
|
Ok I cannot merge from a phone due to the failure (thanks github) so if any other committer is willing to push the button please do. |
tajila
pushed a commit
to tajila/openj9
that referenced
this pull request
Jul 11, 2019
* Place JVMImage instance into JVMImagePortLibrary - created wrapper around omr port library and added jvmimage - placed pointer to wrapper in J9JavaVM - changed all functions to rely on vm reference or jvmimageportlibrary Signed-off-by: akshayben [email protected]
hzongaro
pushed a commit
to hzongaro/openj9
that referenced
this pull request
Mar 26, 2020
…sandbox Implment monitor enter/exit for valuetype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we don't properly IlGeneratorMethodDetails, however that
hasn't harmed us because it has no state. However, I'm trying to add a
field to the OMR::IlGeneratorMethodDetails which will require it to be
initalized, so this commit adds the required call to the parent
constructor.
Signed-off-by: Matthew Gaudet [email protected]