Fix doPrivilegedWithCombiner(action) context for domainCombiner access #15871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshipton
reviewed
Sep 12, 2022
Fixed doPrivilegedWithCombiner(action) with AccessControlContext created via doPrivilegedWithCombinerHelper(); Fixed the doPrivilegedWithCombiner test to perform permission check according to the caller's protection domain, not the upper doPrivileged AccessControlContext. Signed-off-by: Jason Feng <[email protected]>
JasonFengJ9
force-pushed
the
doprivdc
branch
from
e6a3807 to
caebf89
Compare
|
Merging based on the internal testing. |
pshipton
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
doPrivilegedWithCombiner(action)contextfordomainCombineraccessFixed
doPrivilegedWithCombiner(action)withAccessControlContextcreated viadoPrivilegedWithCombinerHelper();Fixed the
doPrivilegedWithCombinertest to perform permission check according to the caller's protection domain, not the upperdoPrivileged AccessControlContext.closes #14803
related to internal workitem
Manually verified the test in question, and also run internal personal build
Signed-off-by: Jason Feng [email protected]