Exempt BCV_SPECIAL_INIT from being set with top in mergeStacks #11753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change is to reinforce the initial intention that only a target slot with BCV_SPECIAL_INIT is exempted from being set with top given setInitializedThisStatus() needs to check BCV_SPECIAL_INIT to flag the uninitialized_this object. Fixes: eclipse-openj9#11683,eclipse-openj9#11684,eclipse-openj9#11685 Signed-off-by: Cheng Jin <[email protected]>
|
Already verified in personal builds & internal tests Reviewer: @gacholio |
gacholio
approved these changes
Jan 22, 2021
|
jenkins test sanity win jdk8 |
This was referenced Jan 22, 2021
|
@ChengJin01 note you need to do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is to reinforce the initial intention that only
a target slot with BCV_SPECIAL_INIT is exempted from being
set with top given setInitializedThisStatus() needs to check
BCV_SPECIAL_INIT to flag the uninitialized_this object.
Fixes: #11683, Fixes: #11684, Fixes: #11685
Signed-off-by: Cheng Jin [email protected]