Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JDK8 windows compiles to use Visual Studio 2013 #10892

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

jdekonin
Copy link
Contributor

@jdekonin jdekonin commented Oct 14, 2020

@jdekonin
Copy link
Contributor Author

jenkins test sanity win32,win jdk8

@jdekonin jdekonin marked this pull request as draft October 15, 2020 00:43
@jdekonin jdekonin changed the title WIP: Update JDK8 windows compiles to use Visual Studio 2013 Update JDK8 windows compiles to use Visual Studio 2013 Oct 15, 2020
@jdekonin
Copy link
Contributor Author

jenkins test sanity win32,win jdk8 depends ibmruntimes/openj9-openjdk-jdk8#449

@pshipton
Copy link
Member

@jdekonin conflicts now.

@jdekonin
Copy link
Contributor Author

I'm not surprised, but easy enough to correct.

jenkins test sanity win32,win jdk8 depends ibmruntimes/openj9-openjdk-jdk8#449

@jdekonin
Copy link
Contributor Author

ibmruntimes/openj9-openjdk-jdk8#449 will need to be reviewed and merged at the same time as this PR.

@keithc-ca
Copy link
Contributor

Jenkins test sanity win,win32 jdk8 depends ibmruntimes/openj9-openjdk-jdk8#449

@pshipton
Copy link
Member

I've added the depends:doc label as we need to update the build environments in https://www.eclipse.org/openj9/docs/openj9_support/
I can take care of that.

@pshipton
Copy link
Member

@jdekonin pls confirm the VS2013 version (update 5?) we have installed.

@jdekonin
Copy link
Contributor Author

Yes, 40629 is VS2013 update 5. All windows systems at on the same level.

08:31:27  * Toolchain:      microsoft (Microsoft Visual Studio 2013)
08:31:27  * C Compiler:     Version 18.00.40629 (at /cygdrive/c/progra~2/micros~3.0/vc/bin/cl)
08:31:27  * C++ Compiler:   Version 18.00.40629 (at /cygdrive/c/progra~2/micros~3.0/vc/bin/cl)

@pshipton pshipton merged commit 63436e4 into eclipse-openj9:master Nov 4, 2020
@pshipton
Copy link
Member

pshipton commented Nov 4, 2020

Jumped the gun. There is a merge conflict in ibmruntimes/openj9-openjdk-jdk8#449 that needs to be resolved first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants