Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install NASM on Windows build machines #3461

Closed
0xdaryl opened this issue Oct 26, 2018 · 4 comments
Closed

Install NASM on Windows build machines #3461

0xdaryl opened this issue Oct 26, 2018 · 4 comments
Labels
comp:build comp:jit

Comments

@0xdaryl
Copy link
Contributor

0xdaryl commented Oct 26, 2018

Issue #2841 required NASM to be installed on all x86 build machines, but this only appears to have been completed on Linux x86 (and the issue was closed).

This issue is to track completing this work on Windows as well.

@nbhuiyan @pshipton @jdekonin @DanHeidinga
@nbhuiyan nbhuiyan mentioned this issue Oct 26, 2018
Closed
7 tasks
@jdekonin
Copy link
Contributor

https://www.nasm.us/pub/nasm/releasebuilds/2.13.03/win64/ should work for 32/64bit windows platforms. Please correct me if I am wrong there.

@nbhuiyan
Copy link
Member

@jdekonin AFAIK, that version will only run on 64bit Windows, but can generate objects for both 32 and 64 bit targets

@nbhuiyan nbhuiyan mentioned this issue Oct 29, 2018
Merged
@jdekonin jdekonin mentioned this issue Oct 31, 2018
Merged
@jdekonin
Copy link
Contributor

fyi nasm is already installed on the 1 mac that is in use already.

jdekonin added a commit to jdekonin/openj9 that referenced this issue Nov 1, 2018
@jdekonin
Add nasm to path for windows pipelines
65fe4ba 
* [skip ci]
* v2.13.03 installed as per eclipse-openj9#3461

Signed-off-by: Joe deKoning <[email protected]>
acrowthe pushed a commit to acrowthe/openj9 that referenced this issue Nov 5, 2018
@jdekonin @acrowthe
Add nasm to path for windows pipelines
313f027 
* [skip ci]
* v2.13.03 installed as per eclipse-openj9#3461

Signed-off-by: Joe deKoning <[email protected]>
@jdekonin
Copy link
Contributor

This work is complete, the issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:build comp:jit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@0xdaryl @pshipton @jdekonin @nbhuiyan