Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"jenkins test all" includes jdk11 but should not #2539

Closed
pshipton opened this issue Aug 2, 2018 · 6 comments
Closed

"jenkins test all" includes jdk11 but should not #2539

pshipton opened this issue Aug 2, 2018 · 6 comments

Comments

@pshipton
Copy link
Member

pshipton commented Aug 2, 2018

"jenkins test all" is not supposed to include jdk11 right now, since it doesn't compile and pass the tests. However it does seem to include jdk11, see #2524 or #2044

@pshipton
Copy link
Member Author

pshipton commented Aug 2, 2018

@jdekonin

@DanHeidinga
Copy link
Member

Any update on this @jdekonin ?

@jdekonin
Copy link
Contributor

jdekonin commented Aug 7, 2018

The JDK11 jobs were updated to stop doing this the morning after the ticket was opened. But there were some modifications to triggers suggested and requested that @vsebe, @AdamBrousseau and I have been investigating with this as the reference issue.

I posted in the #committers-public channel last week with some details.

@pshipton
Copy link
Member Author

pshipton commented Sep 10, 2018

As per the openj9-dev mailing list, @jdekonin wrote:

"
Please note that triggers for pull request compilation and test are changing, or at least this is the proposal for change.

The primary reason driving this proposal is for more targeted compilation/testing in pull requests which in turn will free more machine resources for other pull request testing and/or daily builds. As new releases and platforms are added, the existing machine resources are often laboring to keep up to the workload.

The current permitted use, is that all is accepted for platforms, test levels and release arguments. The proposal is that all will only be valid for platforms. Only a specific release, e.g. one of JDK8,JDK10,JDK11,JDKN; or one or more comma separated releases, e.g. JDK8,JDK11; would be accepted. Only specific test levels would be valid, e.g. sanity or extended.

A commonly used example, jenkins compile all all for example will need to be entered as jenkins compile all jdk8,jdk10,jdk11. Another commonly used example, jenkins test all all all would become jenkins test sanity,extended all jdk8,jdk10,jdk11

Documentation will be updated via #2539, comment/concerns can be posted to this issue or reply to the email thread.
"

@pshipton
Copy link
Member Author

I assume (and expect) jenkins test sanity all won't do anything, as the jdk levels will need to be specified?

@jdekonin
Copy link
Contributor

Correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants