Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newly enabled jvmti tests should be renamed (remove extended from name) #2147

Open
smlambert opened this issue Jun 11, 2018 · 6 comments
Open

Comments

@smlambert
Copy link
Contributor

Some jvmti tests are named jvmti_extended but are tagged as "sanity" level. In general, we should avoid using the level in the name of a test, as it is confusing when it doesn't match the level its in, and it makes for more changes if we wish to move a test into a different level.

@llxia
Copy link
Contributor

llxia commented Jul 16, 2018

This file already has a test named cmdLineTester_jvmtitests. We cannot simply remove _extended as our current infrastructure does not support test with same name and subsets. I will update the level to extended, so it matches with the name.

Please let me know if there is any other suggestion for the name.

@pshipton
Copy link
Member

pshipton commented Jul 16, 2018

We should keep the tests as sanity as they have been traditionally run in sanity.

The group seems to only consist of 2 tests, rc015 and rc016. rc016 mentions HCR extended mode so perhaps that could exlain the name. These tests run in modes with jdwp enabled, so perhaps call them "_debug".

@pshipton
Copy link
Member

pshipton commented Jul 16, 2018

@gacholio any suggestions how we can rename cmdLineTester_jvmtitests_extended so its not confused with extended (vs sanity) testing? See the last 2 comments.

@gacholio
Copy link
Contributor

I'd agree to rename them to debug, or just roll them into one of the other buckets.

@llxia
Copy link
Contributor

llxia commented Jul 20, 2018

Thanks. I will change the name to cmdLineTester_jvmtitests_debug and disable the test until #2129 is resolved. We can roll this test into one of the other buckets when it is all clear.

llxia added a commit to llxia/openj9 that referenced this issue Jul 23, 2018
- disable cmdLineTester_jvmtitests_extended on win until eclipse-openj9#2129 is fixed
- rename cmdLineTester_jvmtitests_extended to
cmdLineTester_jvmtitests_debug

Issue: eclipse-openj9#2129 eclipse-openj9#2147
[ci skip]

Signed-off-by: lanxia <[email protected]>
fengxue-IS pushed a commit to fengxue-IS/openj9 that referenced this issue Jul 24, 2018
- disable cmdLineTester_jvmtitests_extended on win until eclipse-openj9#2129 is fixed
- rename cmdLineTester_jvmtitests_extended to
cmdLineTester_jvmtitests_debug

Issue: eclipse-openj9#2129 eclipse-openj9#2147
[ci skip]

Signed-off-by: lanxia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants