-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newly enabled jvmti tests should be renamed (remove extended from name) #2147
Comments
This file already has a test named Please let me know if there is any other suggestion for the name. |
We should keep the tests as sanity as they have been traditionally run in sanity. The group seems to only consist of 2 tests, rc015 and rc016. rc016 mentions HCR extended mode so perhaps that could exlain the name. These tests run in modes with jdwp enabled, so perhaps call them "_debug". |
@gacholio any suggestions how we can rename cmdLineTester_jvmtitests_extended so its not confused with extended (vs sanity) testing? See the last 2 comments. |
I'd agree to rename them to debug, or just roll them into one of the other buckets. |
Thanks. I will change the name to |
- disable cmdLineTester_jvmtitests_extended on win until eclipse-openj9#2129 is fixed - rename cmdLineTester_jvmtitests_extended to cmdLineTester_jvmtitests_debug Issue: eclipse-openj9#2129 eclipse-openj9#2147 [ci skip] Signed-off-by: lanxia <[email protected]>
- disable cmdLineTester_jvmtitests_extended on win until eclipse-openj9#2129 is fixed - rename cmdLineTester_jvmtitests_extended to cmdLineTester_jvmtitests_debug Issue: eclipse-openj9#2129 eclipse-openj9#2147 [ci skip] Signed-off-by: lanxia <[email protected]>
Some jvmti tests are named jvmti_extended but are tagged as "sanity" level. In general, we should avoid using the level in the name of a test, as it is confusing when it doesn't match the level its in, and it makes for more changes if we wish to move a test into a different level.
The text was updated successfully, but these errors were encountered: