Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JEP 327 Unicode 10 #1875

Closed
pshipton opened this issue May 9, 2018 · 6 comments
Closed

JEP 327 Unicode 10 #1875

pshipton opened this issue May 9, 2018 · 6 comments

Comments

@pshipton
Copy link
Member

pshipton commented May 9, 2018

https://bugs.openjdk.java.net/browse/JDK-8182490

This is an "Epic" to contain requirements for supporting this JEP on OpenJ9.

@pshipton
Copy link
Member Author

Since #1786 OpenJ9 no longer has any Unicode dependencies in String.toUppercase() or String.toLowercase(), the implementations are in OpenJDK.

Closing since there shouldn't be any OpenJ9 changes required.

@pshipton
Copy link
Member Author

pshipton commented May 24, 2018

@andrewcraik mentioned, the JIT still has to upper and to lower implementations of the upper and lower case functions so those need to be checked. See toUpperHWOptimized as well as any recognized methods added for the StringLatin1 and StringUTF16 helpers.

@pshipton pshipton reopened this May 24, 2018
@pshipton
Copy link
Member Author

@andrewcraik is there anything further from JIT required for this change?

I note there was a test failure still outstanding related to the change to Unicode 10.
It should be visible in https://ci.eclipse.org/openj9/job/Test-sanity.functional-JDK11-linux_390-64_cmprssptrs/17/ although jenkins isn't responding atm so I can't double check. Will open an Issue for this failure when jenkins returns.

@pshipton
Copy link
Member Author

Opened #2890

@fjeremic
Copy link
Contributor

@andrewcraik mentioned, the JIT still has to upper and to lower implementations of the upper and lower case functions so those need to be checked. See toUpperHWOptimized as well as any recognized methods added for the StringLatin1 and StringUTF16 helpers.

I don't think so. We only accelerate "en" locale which is effectively the ASCII subset of UTF16:

https://github.com/eclipse/openj9/blob/298cfabf56acfce0cf1ba14e3f8f98debb6e601e/jcl/src/java.base/share/classes/java/lang/String.java#L2807-L2826

Any changes to Unicode standard will not affect the JIT intrinsics.

@pshipton
Copy link
Member Author

Closing since nothing is required other than fixing the test #2890

fjeremic added a commit to fjeremic/openj9 that referenced this issue Sep 18, 2018
According to eclipse-openj9#1875 the Unicode 10 will be used for Java 11. We must
update our Lithuanian tests with the new codepoints as per [1].

[1] https://www.unicode.org/Public/10.0.0/ucd/extracted/DerivedCombiningClass.txt

Fixes: eclipse-openj9#2890

Signed-off-by: Filip Jeremic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants