-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JDK19] JVMTI VirtualThread[Mount|UnMount] Events #16167
Comments
Is somebody taking care of excluding those tests? |
@fengxue-IS Can you confirm if you plan to exclude the above tests while enabling the fixed tests? |
yes, I've created https://github.com/fengxue-IS/aqa-tests/tree/loom3 to address this, still testing to make sure it covers all cases |
@dipak-bagadiya Can you look at this issue? The solution will be similar to the The only difference is that the openj9/runtime/jvmti/jvmtiExtensionMechanism.c Lines 737 to 743 in 3f2deca
fyi @fengxue-IS @tajila |
TODO: Add more details. Related: eclipse-openj9#16167 Signed-off-by: Dipak Bagadiya <[email protected]>
JVMTI VirtualThreadMount and VirtualThreadUnMount events are part of the JVMTI Extension API which is not covered by the JVMTI documentation. The following JVMTI extension events are implemented: - VirtualThreadmount: Trigger/Hook the Virtual thread mount event. - VirtualThreadUnmount: Trigger/Hook the Virtual thread unmount event. Related: eclipse-openj9#16167 Signed-off-by: Dipak Bagadiya <[email protected]> Signed-off-by: Babneet Singh <[email protected]>
Currently, extension event numbers are hard-coded in the tests. This is invalid since the extension event numbers can vary between implementations. Instead, GetExtensionEvents should be used to derive the extension event numbers. Related: eclipse-openj9/openj9#16501 Related: eclipse-openj9/openj9#16167 Signed-off-by: Babneet Singh <[email protected]>
Currently, extension event numbers are hard-coded in the tests. This is invalid since the extension event numbers can vary between implementations. Instead, GetExtensionEvents should be used to derive the extension event numbers. Related: eclipse-openj9/openj9#16501 Related: eclipse-openj9/openj9#16167 Signed-off-by: Babneet Singh <[email protected]>
Currently, extension event numbers are hard-coded in the tests. This is invalid since the extension event numbers can vary between implementations. Instead, GetExtensionEvents should be used to derive the extension event numbers. Related: eclipse-openj9/openj9#16501 Related: eclipse-openj9/openj9#16167 Signed-off-by: Babneet Singh <[email protected]>
Currently, extension event numbers are hard-coded in the tests. This is invalid since the extension event numbers can vary between implementations. Instead, GetExtensionEvents should be used to derive the extension event numbers. Related: eclipse-openj9/openj9#16501 Related: eclipse-openj9/openj9#16167 Signed-off-by: Babneet Singh <[email protected]>
Currently, extension event numbers are hard-coded in the tests. This is invalid since the extension event numbers can vary between implementations. Instead, GetExtensionEvents should be used to derive the extension event numbers. Related: eclipse-openj9/openj9#16501 Related: eclipse-openj9/openj9#16167 Signed-off-by: Babneet Singh <[email protected]>
Currently, extension event numbers are hard-coded in the tests. This is invalid since the extension event numbers can vary between implementations. Instead, GetExtensionEvents should be used to derive the extension event numbers. Related: eclipse-openj9/openj9#16501 Related: eclipse-openj9/openj9#16167 Signed-off-by: Babneet Singh <[email protected]>
Reopening since the disabled tests still need to be re-enabled. |
Currently, extension event numbers are hard-coded in the tests. This is invalid since the extension event numbers can vary between implementations. Instead, GetExtensionEvents should be used to derive the extension event numbers. Related: eclipse-openj9/openj9#16501 Related: eclipse-openj9/openj9#16167 Signed-off-by: Babneet Singh <[email protected]>
Currently, extension event numbers are hard-coded in the tests. This is invalid since the extension event numbers can vary between implementations. Instead, GetExtensionEvents should be used to derive the extension event numbers. Related: eclipse-openj9/openj9#16501 Related: eclipse-openj9/openj9#16167 Signed-off-by: Babneet Singh <[email protected]>
Currently, extension event numbers are hard-coded in the tests. This is invalid since the extension event numbers can vary between implementations. Instead, GetExtensionEvents should be used to derive the extension event numbers. Related: eclipse-openj9/openj9#16501 Related: eclipse-openj9/openj9#16167 Signed-off-by: Babneet Singh <[email protected]>
Currently, extension event numbers are hard-coded in the tests. This is invalid since the extension event numbers can vary between implementations. Instead, GetExtensionEvents should be used to derive the extension event numbers. Related: eclipse-openj9/openj9#16501 Related: eclipse-openj9/openj9#16167 Signed-off-by: Babneet Singh <[email protected]>
Currently, extension event numbers are hard-coded in the tests. This is invalid since the extension event numbers can vary between implementations. Instead, GetExtensionEvents should be used to derive the extension event numbers. Related: eclipse-openj9/openj9#16501 Related: eclipse-openj9/openj9#16167 Signed-off-by: Babneet Singh <[email protected]>
The JVMTI VirtualThread[Mount|UnMount] events were implemented in #16501. For JDK20, no test is disabled due to this issue in https://github.com/adoptium/aqa-tests/blob/master/openjdk/excludes/ProblemList_openjdk20-openj9.txt. Thus, closing this issue. |
JVMTI VirtualThreadMount and VirtualThreadUnMount events are part of the JVMTI Extension API, which is not covered by the JVMTI documentation. So, they don't need to be supported for the current Java 19 milestone.
Their implementation will be similar to the VirtualThreadStart and VirtualThreadEnd events. VirtualThreadStart and VirtualThreadEnd events are only triggered during the first mount and last unmount respectively. But, VirtualThreadMount and VirtualThreadUnMount events will be triggered on each mount and unmount respectively.
The following JVMTI serviceability tests will need to be disabled until support for the VirtualThreadMount and VirtualThreadUnMount events is introduced:
The text was updated successfully, but these errors were encountered: