Add Windows support for -Xgc:concurrentScavenge #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update -Xgc topic to add platform. Update What's new for concurrentScavenge entry. Few minor tidy up changes in what's new including adding in Supported platforms and binaries, which mentions the early macOS build. Signed-off-by: Sue Chaplain <[email protected]>
SueChaplain
force-pushed
the
win_scavenge
branch
from
ed91c14 to
98f6a00
Compare
|
@pshipton - In the version0.12.md file I added a link to the nightlies page for the early macOS binary in addition to adding the concurrentScavenge support for Windows. Please feel free to merge - rest of the team are away for Christmas now. I am working Christmas eve morning if you want any changes in this PR. |
|
I don't see why we would merge in changes for CS on Windows when the feature isn't yet delivered. |
|
It does seem like eclipse-openj9/openj9#4109 will be merged shortly. |
pshipton
approved these changes
Dec 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update -Xgc topic to add platform.
Update What's new for concurrentScavenge entry.
Few minor tidy up changes in what's new including
adding in Supported platforms and binaries, which
mentions the early macOS build.
Closes #172
Signed-off-by: Sue Chaplain [email protected]