Don't wait indefinitely to gather stack traces #6685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barrier_block_until_poked() may signal failure with a value other than -1. In particular, if the controlling thread decides time has run out, it closes the pipe which may cause poll() to signal POLLNVAL in revents for waiting threads, leading them to see barrier_block_until_poked() return -2. Also general cleanup; use OMR_ARE_ANY_BITS_SET, OMR_ARE_NO_BITS_SET. Signed-off-by: Keith W. Campbell <[email protected]>
keithc-ca
requested review from
charliegracie,
youngar,
rwy7 and
babsingh
as code owners
|
jenkins build all |
babsingh
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
barrier_block_until_poked()may signal failure with a value other than -1. In particular, if the controlling thread decides time has run out, it closes the pipe which may causepoll()to signalPOLLNVALinreventsfor waiting threads, leading them to seebarrier_block_until_poked()return -2.Also general cleanup; use
OMR_ARE_ANY_BITS_SET(),OMR_ARE_NO_BITS_SET().