Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset _defMergedNodes in global VP on every basic block #6121

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Reset _defMergedNodes in global VP on every basic block #6121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion compiler/optimizer/OMRValuePropagation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4081,7 +4081,6 @@ void TR::GlobalValuePropagation::processStructure(TR_StructureSubGraphNode *node
TR_RegionStructure *region = node->getStructure()->asRegion();
if (region)
{
_defMergedNodes->empty();
if (region->isAcyclic())
{
processAcyclicRegion(node, lastTimeThrough, insideLoop);
Expand All @@ -4097,6 +4096,10 @@ void TR::GlobalValuePropagation::processStructure(TR_StructureSubGraphNode *node
}
else
{
// Only commoned nodes within a block need to be set in _defMergedNodes.
// So it should be reset here
TR_ASSERT_FATAL(!node->getStructure()->asBlock()->getBlock()->isExtensionOfPreviousBlock(), "This optimization does not run on extended blocks");
_defMergedNodes->empty();
processBlock(node, lastTimeThrough, insideLoop);
}
}
Expand Down