Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use custom function to format TRIL code #5587

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Use custom function to format TRIL code #5587

wants to merge 22 commits into from

Commits on Dec 15, 2023

  1. Introduce new custom function to format TRIL code 

    This commit introduces new template function `Tril::format()` that
is to be used to format TRIL code in tests designed as drop-in
replacement for `std::snprintf()` except that:

  1. support only a (used) subset of *printf-like conversion specifiers,
  2. "modifiers" like l, ll, h, hh, j, I, I32 and I64 are ignored and
  3. used conversion specifier and a static type of actual parameter must
     match (it is not possible to format `double` using `%X`
     conversion)

Use of a template function and static types rather than *printf-like
conversion flags allows `Tril::format()` to be used in another templates
and thus will allow to further simplify test creation.

Moreover, this makes TRIL formatting independent on `std::snprintf()`
which is known to behave differently on different systems. Therefore,
this commit introduces indirection required to fix eclipse-omr#5183 and eclipse-omr#5324.
    @janvrany
    janvrany committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    b7b437f View commit details
    Browse the repository at this point in the history

  2. Add poor man's replacement for std::make_signed 

    Since XLC compiler used at a time on AIX and ZOS does not support
std::make_signed, this commit provides simplified drop-in replacement
for use in reinterpret_as_signed().

Once XLC compiler on AIX and ZOS is upgraded to support std::make_signed,
this simplified version can be removed in favour of standard version.
    @janvrany
    janvrany committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    0ec553b View commit details
    Browse the repository at this point in the history

  3. Like previous commit, but for std::is_same

    @janvrany
    janvrany committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    f14bdc2 View commit details
    Browse the repository at this point in the history

  4. Like previous commit, but for std::is_integral

    @janvrany
    janvrany committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    671ba7a View commit details
    Browse the repository at this point in the history

  5. Like previous commit, but for std::is_unsigned

    @janvrany
    janvrany committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    9d2ff16 View commit details
    Browse the repository at this point in the history

  6. Like previous commit, but for std::is_pointer

    @janvrany
    janvrany committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    8671282 View commit details
    Browse the repository at this point in the history

  7. Like previous commit, but for std::is_floating_point

    @janvrany
    janvrany committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    e8cfd53 View commit details
    Browse the repository at this point in the history

  8. Convert ArithmeticTest tests to use Tril::format() instead of std::sn… 

    …printf()
    @janvrany
    janvrany committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    4db9382 View commit details
    Browse the repository at this point in the history

  9. Convert ArrayTest tests to use Tril::format() instead of std::snprintf()

    @janvrany
    janvrany committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    995ea89 View commit details
    Browse the repository at this point in the history

  10. Convert BitPermute tests to use Tril::format() instead of std::snprin… 

    …tf()
    @janvrany
    janvrany committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    22072f1 View commit details
    Browse the repository at this point in the history

  11. Convert CallTest tests to use Tril::format() instead of std::snprintf()

    @janvrany
    janvrany committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    3308657 View commit details
    Browse the repository at this point in the history

  12. Convert CompareTest tests to use Tril::format() instead of std::snpri… 

    …ntf()
    @janvrany
    janvrany committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    204b896 View commit details
    Browse the repository at this point in the history

  13. Convert IfxcmpgeReductionTest tests to use Tril::format() instead of … 

    …std::snprintf()
    @janvrany
    janvrany committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    e9251af View commit details
    Browse the repository at this point in the history

  14. Convert LinkageTest tests to use Tril::format() instead of std::snpri… 

    …ntf()
    @janvrany
    janvrany committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    f7503d7 View commit details
    Browse the repository at this point in the history

  15. Convert LogicalTest tests to use Tril::format() instead of std::snpri… 

    …ntf()
    @janvrany
    janvrany committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    9b01afe View commit details
    Browse the repository at this point in the history

  16. Convert LongAndAsRotateTest tests to use Tril::format() instead of st… 

    …d::snprintf()
    @janvrany
    janvrany committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    de4668f View commit details
    Browse the repository at this point in the history

  17. Convert MaxMinTest tests to use Tril::format() instead of std::snprin… 

    …tf()
    @janvrany
    janvrany committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    18e04eb View commit details
    Browse the repository at this point in the history

  18. Convert SelectTest tests to use Tril::format() instead of std::snprin… 

    …tf()
    @janvrany
    janvrany committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    0760347 View commit details
    Browse the repository at this point in the history

  19. Convert ShiftAndRotateTest tests to use Tril::format() instead of std… 

    …::snprintf()
    @janvrany
    janvrany committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    505dbdd View commit details
    Browse the repository at this point in the history

  20. Convert SimpifierFoldAbsNegTest tests to use Tril::format() instead o… 

    …f std::snprintf()
    @janvrany
    janvrany committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    13024c5 View commit details
    Browse the repository at this point in the history

  21. Convert TypeConversionTest tests to use Tril::format() instead of std… 

    …::snprintf()
    @janvrany
    janvrany committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    47c882c View commit details
    Browse the repository at this point in the history

  22. Convert VectorTest tests to use Tril::format() instead of std::snprin… 

    …tf()
    @janvrany
    janvrany committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    ad7275b View commit details
    Browse the repository at this point in the history